[Harness] Merge the Generator and the Factory in a same object and rename namespace. - #8222
Conversation
Remove two classes that are not really needed and a method. We moved to named tuples to make things simpler. Unfortunally C# does not support: ```csharp using MyNamedTuple = (string Name, double value, bool answer); ``` But we have to live with this. Makes the namespace simpler and removes confusion with the already present project classes that are more widely used.
The class is not really needed. Move to a tuple, make the definition of the group test project nicer since the dictionary initiallization makes it cleaner.
mandel-macaque
added
run-all-tests
|
PR is a draft because is pointing to the parent branch, remove-test-project-info. Will be a normal PR once the parent branch lands, doing this to simplify the review process. |
…name namespace. The Generator and the Factory classes are a xamarin-macios thing. Initially, they were separated because the code that generated the bcl tests was not inside xharness. That is not longer the case. We can merge both classes, generalize the namespace and be more prepared to move out of the xamarin-macios repo.
c6138a7 to
ef03b16
Compare
|
Build failure 🔥 Build failed 🔥 |
|
Build failure Test results1 tests failed, 1047 tests' device not found, 183 tests passed.Failed tests
|
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results1 tests failed, 184 tests passed.Failed tests
|
|
Please also rename |
|
Build failure Test results3 tests failed, 1047 tests' device not found, 181 tests passed.Failed tests
|
|
Build failure |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results6 tests failed, 179 tests passed.Failed tests
|
|
Build failure Test results2 tests failed, 1047 tests' device not found, 182 tests passed.Failed tests
|
|
@premun BCLTestProjectGenerator is specific for xamarin-macios and will not leave the project. The prefix BCL is correct because it is just used for the BCL tests. |
|
Build success |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: There is already a newer build in progress (#5) |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: script returned exit code 128 |
5 participants
The Generator and the Factory classes are a xamarin-macios thing.
Initially, they were separated because the code that generated the bcl
tests was not inside xharness. That is not longer the case. We can merge
both classes, generalize the namespace and be more prepared to move out
of the xamarin-macios repo.