[Harness] Ensure we do not throw an exception if we do not have tasks. - #8272
Merged
Conversation
The First extension will throw an exception if the list is empty. Use FirstOrDefault, check if the devices are null and return the test as Ignored. fixes: #8271
premun
approved these changes
Apr 2, 2020
Contributor
|
Build success |
rolfbjarne
requested changes
Apr 3, 2020
| var devices = executingTasks.First ().Simulators; | ||
| var devices = executingTasks.FirstOrDefault ()?.Simulators; | ||
| if (devices == null) { | ||
| ExecutionResult = TestExecutingResult.Ignored; |
Member
There was a problem hiding this comment.
No simulator means the test should fail with TestExecutingResult.DeviceNotFound.
rolfbjarne
approved these changes
Apr 3, 2020
Contributor
|
Build success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The First extension will throw an exception if the list is empty. Use
FirstOrDefault, check if the devices are null and return the test as
Ignored.
fixes: #8271