Skip to content

Add AutoFill CredentialProvider NSExtensionPoint support - #9030

Merged
rolfbjarne merged 3 commits into
dotnet:mainfrom
kiddailey:AddCredentialProviderExtensionSupport
Jul 13, 2020
Merged

Add AutoFill CredentialProvider NSExtensionPoint support#9030
rolfbjarne merged 3 commits into
dotnet:mainfrom
kiddailey:AddCredentialProviderExtensionSupport

Conversation

@kiddailey

Copy link
Copy Markdown
Contributor

This commit adds support for AutoFill Credential Provider extensions to be built. Specifically, this resolves the issue with unrecognized extension point warnings being issued during the build process for Credential Providers. A related change to Xamarin.MacDev has already been merged.

For more information, see posted issue at: #9000

@rolfbjarne

Copy link
Copy Markdown
Member

build

@spouliot spouliot added the community Community contribution ❤ label Jul 8, 2020
@chamons

chamons commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Great stuff - thanks for the contribution!

@mandel-macaque

Copy link
Copy Markdown
Contributor

Will backport this do d16-8 and will do an insertion with it so that is available ASAP.

@monojenkins

Copy link
Copy Markdown
Contributor

Build success
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@rolfbjarne rolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry here too?

https://github.com/xamarin/xamarin-macios/blob/1b09465acf36b9311e202103aefe8c796482972d/Versions-ios.plist.in#L92-L136

This is used by the IDEs when listing the possible deployment targets for an extension.

With that addition this should be good to go.

@kiddailey

Copy link
Copy Markdown
Contributor Author

Done and I think I've got it correct.

Thanks for pointing that out! I'm (slowly) gathering a list of missing extension points and am planning on putting in pull requests for those as well, so this definitely helps me make sure they're complete.

@rolfbjarne rolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect!

@rolfbjarne

Copy link
Copy Markdown
Member

build

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure
Provisioning succeeded
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 90 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed Known issue: HE0038)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution ❤

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants