Skip to content

[xharness] Try harder to make lldb quit after trying to get a backtrace. #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Jul 17, 2020
Merged

[xharness] Try harder to make lldb quit after trying to get a backtrace. #9119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Execution/ProcessManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ static async Task KillTreeAsyncInternal (int pid, ILog log, bool? diagnostics =

foreach (var diagnose_pid in pids) {
var template = Path.GetTempFileName ();
var templateQuit = Path.GetTempFileName ();
try {
var commands = new StringBuilder ();
using (var dbg = new Process ()) {
Expand All @@ -259,15 +260,17 @@ static async Task KillTreeAsyncInternal (int pid, ILog log, bool? diagnostics =
commands.AppendLine ("detach");
commands.AppendLine ("quit");

@spouliot spouliot Jul 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that quit still needed ?

@rolfbjarne rolfbjarne Jul 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not, but I wondered if earlier versions of lldb (on older macOS versions) would still support multiple --source arguments, so I left it there. I figured that leaving it would be the safest option.

dbg.StartInfo.FileName = "/usr/bin/lldb";
dbg.StartInfo.Arguments = StringUtils.FormatArguments ("--source", template);
dbg.StartInfo.Arguments = StringUtils.FormatArguments ("--source", template, "--source", templateQuit);
File.WriteAllText (template, commands.ToString ());
File.WriteAllText (templateQuit, "quit\n");

log.WriteLine ($"Printing backtrace for pid={pid}");
await RunAsyncInternal (dbg, log, log, log, TimeSpan.FromSeconds (30), diagnostics: false);
}
} finally {
try {
File.Delete (template);
File.Delete (templateQuit);
} catch {
// Don't care
}
Expand Down