[msbuild] Default 'BundlerDebug' to 'true' if no other option is set and we're building for a 'Debug' configuration. - #9247
Merged
Conversation
…and we're building for a 'Debug' configuration. It's somewhat of a breaking change, since previously Xamarin.Mac would default to 'false' if no value was set. It should be exceedingly rare though, since it's set in all the template projects. It makes the behavior a bit more intuitive for .NET projects, since then the values might not be set because of the simplified project files.
rolfbjarne
added
not-notes-worthy
chamons
approved these changes
Jul 30, 2020
whitneyschmidt
approved these changes
Jul 30, 2020
Contributor
|
Build success |
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 ✅ Provisioning succeeded View packages
✅ API Diff (from stable) Test results2 tests failed, 182 tests passed.Failed tests
|
Member
Author
|
Test failures are unrelated
|
emaf
approved these changes
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's somewhat of a breaking change, since previously Xamarin.Mac would default
to 'false' if no value was set. It should be exceedingly rare though, since
it's set in all the template projects.
It makes the behavior a bit more intuitive for .NET projects, since then the
values might not be set because of the simplified project files.