Skip to content

fix(durable-jobs): treat shutdown cancellation as normal - #10285

Merged
ReubenBond merged 2 commits into
dotnet:mainfrom
ReubenBond:reubenbond-fix-durable-job-cancellation
Jul 21, 2026
Merged

fix(durable-jobs): treat shutdown cancellation as normal#10285
ReubenBond merged 2 commits into
dotnet:mainfrom
ReubenBond:reubenbond-fix-durable-job-cancellation

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Jul 20, 2026

Copy link
Copy Markdown
Member

Fixes #10281

Treats cancellation from LocalDurableJobManager's own shutdown token as expected while preserving unexpected shard failures. Stop now snapshots active shards before cancellation and keeps them tracked through disposal so lifecycle shutdown waits for complete cleanup.

Microsoft Reviewers: Open in CodeFlow

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@ReubenBond ReubenBond changed the title Treat durable job cancellation as normal during shutdown fix(durable-jobs): treat shutdown cancellation as normal Jul 20, 2026
Treat manager-initiated shard cancellation as a normal lifecycle stop while preserving unexpected failures and awaiting shard disposal.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d6fd457e-f731-425a-ac47-09274af658d9
Swallow any OperationCanceledException once the manager shutdown token has been canceled.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d6fd457e-f731-425a-ac47-09274af658d9
@ReubenBond
ReubenBond force-pushed the reubenbond-fix-durable-job-cancellation branch from c6331cf to bdf3e73 Compare July 21, 2026 04:07
@ReubenBond
ReubenBond merged commit e61b0d7 into dotnet:main Jul 21, 2026
62 checks passed
@ReubenBond
ReubenBond deleted the reubenbond-fix-durable-job-cancellation branch July 21, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Treat LocalDurableJobManager cancellation as normal during shutdown

1 participant