Enable wasm aot microbenchmark run - #1902
Merged
Merged
Conversation
…et/performance into alicial/hikeMicro-benchmark
…use the same nuget.config
Make it easier to use custom BenchmarkDotNet sources. Example use:
dotnet build -bl -c Release -p:BenchmarkDotNetSources="\myPath\git\BenchmarkDotNet\" src\benchmarks\micro
To avoid:
src\harness\BenchmarkDotNet.Extensions\BenchmarkDotNet.Extensions.csproj(6,5): error MSB4184: The expression "[MSBuild]::NormalizeDirectory('')" cannot be evaluated. Parameter "path" cannot have zero length.
Lxiamail
commented
Jul 30, 2021
Lxiamail
commented
Jul 30, 2021
Member
|
Currently we have the what looks to be something like 100 files being uploaded as part of the helix workitem. If we want to continue to upload that many files we should look into zipping them up and storing them that way. Details |
Contributor
Author
Files under BDNJobBackUp/Job-* are uploaded for diagnostic only. This PR removes copy back the Job-* folder. |
…rkload property. mark perf_file.WriteAllBytesAsync not run under wasm since async is not supported under wasm
Lxiamail
commented
Aug 4, 2021
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
This nuget,config is used when installs emsdk in performance-setup.sh file
Contributor
Author
|
This PR is finalized. Please review @DrewScoggins |
billwert
reviewed
Aug 4, 2021
billwert
left a comment
billwert
left a comment
Contributor
There was a problem hiding this comment.
Can you summarize the changes that ended up being made? There's a ton of commits here and not a lot of ultimate diff, so I'm curious what the fixes really ended up being.
Comment on lines
+1
to
+6
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project> | ||
| <PropertyGroup> | ||
| <WasmNativeWorkload>false</WasmNativeWorkload> | ||
| </PropertyGroup> | ||
| </Project> |
Contributor
There was a problem hiding this comment.
Why do we need this file in the docs folder?
Contributor
Author
There was a problem hiding this comment.
Good question. :) The goal is put this Directory.Build.props file to a root/parent directory where benchmarkdotnet runs from. Due to we copy docs directory to workitemdirectory, having Directory.Build.props file in the same directory makes it work. However, we should remove ASAP since this could have unexpected back consequences. opened #1909 to track this.
DrewScoggins
approved these changes
Aug 4, 2021
DrewScoggins
left a comment
DrewScoggins
left a comment
Member
There was a problem hiding this comment.
LGTM, but we should either remove the bdn binlog or save it off.
Contributor
Author
Yes, a lot of commits were mostly for trying things out and adding work arounds in private branch. Will squash the merge to clean up history. I added summary of the code change in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR actually doesn't contain much business logic. To summarize: