Copilot/perf binlog download pipeline artifact#5264
Merged
DrewScoggins merged 2 commits intoJul 20, 2026
Merged
Conversation
The two inline binlog download steps in runtime-perf-job.yml still used DownloadBuildArtifacts@0, which was missed by #5262. dotnet/runtime now publishes these binlogs as Pipeline Artifacts (#128498), so migrate the download side to DownloadPipelineArtifact@2, matching #5262's pattern (drop downloadType/checkDownloadedFiles, downloadPath -> targetPath). Paired with the runtime change giving these binlogs stable names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5
Migrate the last inline "Download iOS Sample App" step in runtime-perf-job.yml off DownloadBuildArtifacts@0, completing the move to DownloadPipelineArtifact@2 for all downloads in the perf pipeline YAML (eng/common is Arcade-managed and left as-is). DownloadPipelineArtifact@2 places a named artifact's contents directly in targetPath, without the <artifactName> subfolder that DownloadBuildArtifacts@0 created. The payload-staging globs in run_performance_job.py used "**" without recursive=True, so they only matched one intermediate directory and would miss the now-flattened .binlog/.zip files (fatal for the iOS sample app zip). Make those three globs recursive; recursive=True also still matches the old nested layout, so it is safe across the transition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f47a24b-d0d8-4286-afcc-a1f3d96552c5
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the runtime performance pipeline to download build outputs as pipeline artifacts and adjusts the job payload-prep script to correctly locate downloaded binlog/zip files when they’re nested in artifact folder structures.
Changes:
- Switch Android/iOS artifact download steps from
DownloadBuildArtifacts@0toDownloadPipelineArtifact@2(usingtargetPath). - Fix Python artifact file discovery by enabling recursive
glob()for**/*.binlogand**/*.zippatterns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/run_performance_job.py | Ensures glob("**/...") searches recursively so downloaded binlogs/zips are found and moved to stable names. |
| eng/pipelines/templates/runtime-perf-job.yml | Migrates Android/iOS downloads to DownloadPipelineArtifact@2 and aligns inputs with pipeline-artifact semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LoopedBard3
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.