Update ML.NET to 1.4 - #987
Merged
Merged
Conversation
adamsitnik
commented
Oct 31, 2019
Instead use an empty IDataView to pass into Fit.
eerhardt
approved these changes
Oct 31, 2019
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for doing this @adamsitnik!
Member
Author
|
@eerhardt thank you for the review and the fix! |
billwert
approved these changes
Oct 31, 2019
Contributor
|
@adamsitnik Now that the release version of ML.NET is out (1.4.0 instead of 1.4.0-preview2), does it make sense to update to that (and stick with it?)? |
Member
Author
@BruceForstall yes, I'm already working on it #988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I start working on #896 we need to update the version of ML.NET first