Update .NET Core Sdk version

[ajaybhargavb]

Without this update we get errors during build locally like,

 error NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the l ist of actions below: [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\RazorPageGenerator\RazorPageGenerator.csproj]
 error NU5128: - Add a dependency group for .NETCoreApp5.0 to the nuspec [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\RazorPageGenerator\RazorPageGenerator.csproj]
 error NU5128: - Add lib or ref assemblies for the net50 target framework [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\RazorPageGenerator\RazorPageGenerator.csproj]
 error NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the l ist of actions below: [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\rzls\rzls.csproj]
 error NU5128: - Add a dependency group for .NETCoreApp5.0 to the nuspec [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\rzls\rzls.csproj]
 error NU5128: - Add lib or ref assemblies for the net50 target framework [C:\GitHub\aspnet\AspNetCore-Tooling\src\Razor\src\rzls\rzls.csproj]

[ajaybhargavb]

error : Version 5.0.100-preview.3.20167.11 of the .NET Core SDK requires at least version 16.5.0 of MSBuild. The current available version of MSBuild is 16.4.0.56107. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.

@JunTaoLuo @dougbu is there anything else I need to update?

[Pilchie]

This is the same thing @ViktorHofer is seeing in the template PRs. Will need a new Helix queue with a newer VS.

[ajaybhargavb]

This is the same thing @ViktorHofer is seeing in the template PRs. Will need a new Helix queue with a newer VS.

@Pilchie can you point me to the other PR that uses the new Helix queue?

[Pilchie]

dotnet/aspnetcore#19860 but it doesn't actually do it yet, because we just got the machine images.

[NTaylorMullen]

@ajaybhargavb any reason this shouldn't go in?

[ajaybhargavb]

@ajaybhargavb any reason this shouldn't go in?

Because it fails. And we need a new helix queue to support this. @dotnet/aspnet-build folks, could you share more context on this?

[ViktorHofer]

Right, we are waiting for build images with 16.5 stable on them. This should probably wait another week.

[NTaylorMullen]

@ViktorHofer are we good now?

[ajaybhargavb]

@dougbu is this now unblocked?

[dougbu]

is this now unblocked?

I don't know. Let's see how an SDK from this morning works.

[dougbu]

@rrelyea the test failures seen in this validation build make me very nervous about using recent SDKs anywhere. Generated .nuspec files now contain different <contentFiles> entries

<files include="any/net5.0/Views/Shared/_Layout.cshtml" buildAction="Content" />
<files include="any/net5.0/Views/_ViewImports.cshtml" buildAction="Content" />

and <files> entries such as

<file src="C:\Users\vsagent\AppData\Local\Temp\Razor\adpnpqul.oxa\ClassLibrary\bin\Debug\netcoreapp5.0\ClassLibrary.Views.dll" target="lib\net5.0\ClassLibrary.Views.dll" />

instead of the expected .../netcoreapp5.0/... paths. What impact will these changes have on projects consuming these packages?

Note nothing in this repo targets the net5.0 TFM.

[dougbu]

BTW, changing the default TFM in this repo to net5.0 shouldn't happen until after we get a dependency update from dotnet/runtime with @ViktorHofer's blocked dotnet/runtime#35176 change.

[dougbu]

/ping @rrelyea

[ViktorHofer]

This is now unblocked 🎉🎉🎉. Please update to the latest runtime build which includes the net5.0 tfm change.

[NTaylorMullen]

This is now unblocked 🎉🎉🎉. Please update to the latest runtime build which includes the net5.0 tfm change.

Wooo! Can't wait!

[ajaybhargavb]

Thanks. Will update

[dougbu]

This PR will never pass w/o major changes to workaround perceived TFM mixes due to incomplete changes in the SDK. Suggest closing it in favour of #1873

[ajaybhargavb]

Closing in favor of #1873. Thanks @dougbu