Skip to content

Update credentials suppression - the second round - #125

Merged
aik-jahoda merged 2 commits into
dotnet:mainfrom
aik-jahoda:jajahoda/cred2
Mar 24, 2021
Merged

Update credentials suppression - the second round#125
aik-jahoda merged 2 commits into
dotnet:mainfrom
aik-jahoda:jajahoda/cred2

Conversation

@aik-jahoda

Copy link
Copy Markdown
Contributor

No description provided.

@aik-jahoda
aik-jahoda requested review from danmoseley and wfurt March 24, 2021 12:42
Comment thread .config/CredScanSuppressions.json Outdated
"testservereku.contoso.com.noRC2.pfx",
"testservereku.contoso.com.pfx"
],
"_justification": "Testdata certs"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we note to be explicit that exemptions were approved so we know in future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you suggest something like "Approved testdata certs" ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the suggestion in #126

@aik-jahoda
aik-jahoda merged commit 055ed02 into dotnet:main Mar 24, 2021
@aik-jahoda
aik-jahoda deleted the jajahoda/cred2 branch March 24, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants