-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[cdacreader] Simplify build order and dependencies #104158
Copy link
Copy link
Closed
Labels
area-Infrastructure-coreclrOnly use for closed issuesOnly use for closed issuesenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
Milestone
Metadata
Metadata
Assignees
Labels
area-Infrastructure-coreclrOnly use for closed issuesOnly use for closed issuesenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Done
The original
src/native/managedinfrastructure was developed with the idea that we need to buildlibcdacreader.so/cdacreader.dll(orlibcdacreader.a/cdacreader.abefore static library support was abandoned) ahead of the main CoreCLR build so that we can link to the shared library during the CoreCLR build (specifically during the DAC build).But we don't do that now. Instead the DAC shared library dynamically loads the cDAC using
dlopen/LoadLibraryThat means we don't have a true build-time dependency between the cDAC and the rest of the CoreCLR build. So we don't need to hook it in via
runtime-prereqs.proj. We can add it as a separate subset or as aProjectReferencesome place else. The only requirements are:This is also a first step for any plan to publish the cdacreader separately from the runtime (which is a long-term goal of the cdac effort: it should be possible to distribute and use cdacreader out of band)