Skip to content

Make CoreCLR and Libraries live asset OverridePath/ArtifactPath normalization more consistent #1615

Description

@dagood

These lines take override paths and normalize them before using as artifact dirs:

<!-- Accept override paths for live artifacts. -->
<PropertyGroup>
<CoreCLRArtifactsPath Condition="'$(CoreCLROverridePath)' != ''">$([MSBuild]::NormalizeDirectory('$(CoreCLROverridePath)'))</CoreCLRArtifactsPath>
<LibrariesArtifactsPath Condition="'$(LibrariesOverridePath)' != ''">$([MSBuild]::NormalizeDirectory('$(LibrariesOverridePath)'))</LibrariesArtifactsPath>
</PropertyGroup>

We should consider also doing this for LibrariesAllConfigurationsOverridePath.

It is necessary for LibrariesOverridePath and CoreCLRArtifactsPath, but LibrariesAllConfigurationsOverridePath is not necessary. However, having them all follow the same pattern makes the code more predictable/readable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions