Installer build (corehost) for Linux/OSX failing in official build

[elinor-fung]

Failing on singlefilehost build.

gmake[2]: *** No rule to make target `/root/runtime/artifacts/transport/AllArtifacts/CoreCLRProduct__release/lib/libcoreclr_static.a', needed by `cli/apphost/static/singlefilehost'.  Stop.
gmake[2]: *** Waiting for unfinished jobs....
  [ 88%] Building CXX object cli/apphost/static/CMakeFiles/singlefilehost.dir/__/__/__/corehost.cpp.o
gmake[1]: *** [cli/apphost/static/CMakeFiles/singlefilehost.dir/all] Error 2

cc @swaroop-sridhar @VSadov

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar, @agocke
Notify danmosemsft if you want to be subscribed.

Tagging subscribers to this area: @swaroop-sridhar, @agocke
Notify danmosemsft if you want to be subscribed.

[swaroop-sridhar]

Understood to be caused/triggered by #36847

[swaroop-sridhar]

The problem here, as identified by @jkoritzinsky, is that CoreCLRArtifactsPath is /root/runtime/artifacts/transport/AllArtifacts/CoreCLRProduct__release/... , rather than /root/runtime/artifacts/transport/AllArtifacts/CoreCLRProduct_Linux-x64_release/...

[swaroop-sridhar]

CoreCLRArtifactsPath is computed here.

However, in /root/runtime/src/installer/corehost/build.proj, ArtifactPlatform is not set here because RuntimeIdentifier is not set.

[VSadov]

It looks like RuntimeArtifactsPath is passed correctly to the build and should become CoreCLRArtifactsPath, however later it is overriden because of the condition in:

 <PropertyGroup Condition="
    '$(RuntimeIdentifier)' != '$(OutputRid)' and
    '$(AllArtifactsDownloadPath)' != ''">

which is true if RuntimeIdentifier is not specified.

Perhaps the fix should be

 <PropertyGroup Condition="
    '$(RuntimeIdentifier)' != '' and
    '$(RuntimeIdentifier)' != '$(OutputRid)' and
    '$(AllArtifactsDownloadPath)' != ''">

i.e. - if RuntimeIdentifier is not specified, just let the default value (RuntimeArtifactsPath) be used?

[VSadov]

For reference - we get
/p:RuntimeArtifactsPath=/root/runtime/artifacts/transport/coreclr

And that is where the coreclr binaries are unzipped.

However we also get
/p:AllArtifactsDownloadPath=artifacts/transport/AllArtifacts

which triggers the override, but there is nothing to override to - since RuntimeIdentifier in this case is empty.

[VSadov]

Fixed in #38602