Test failure:Regressions\\coreclr\\GitHub_34094\\Test34094\\Test34094.cmd

[VincentBu]

Run: runtime-coreclr jitstress 20210814.1

Failed test:

CoreCLR windows x86 Checked jitstress2 @ Windows.10.Amd64.Open
- Regressions\\coreclr\\GitHub_34094\\Test34094\\Test34094.cmd

CoreCLR OSX x64 Checked jitstress2 @ OSX.1013.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

CoreCLR Linux x64 Checked jitstress2 @ Ubuntu.1804.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

CoreCLR OSX x64 Checked jitstress1 @ OSX.1013.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

One of error message:

Assert failure(PID 5988 [0x00001764], Thread: 3976 [0x0f88]): Assertion failed '(emitChkAlign == false) || (ins == INS_lea) || ((emitComp->compCodeOpt() == Compiler::SMALL_CODE) && (((size_t)addr & 3) == 0)) || (((size_t)addr & (byteSize - 1)) == 0)' in 'Test34094:TestAvxCompareGreaterThanOrEqualDouble():bool' during 'Emit code' (IL size 270)

File: D:\workspace\_work\1\s\src\coreclr\jit\emitxarch.cpp Line: 11534
Image: C:\h\w\9FF408CA\p\corerun.exe
Return code:      1
Raw output file:      C:\h\w\9FF408CA\w\A79708F5\uploads\Reports\Regressions.coreclr\GitHub_34094\Test34094\Test34094.output.txt
Raw output:
BEGIN EXECUTION
"C:\h\w\9FF408CA\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false" Test34094.dll
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=C:\h\w\9FF408CA\p
C:\h\w\9FF408CA\w\A79708F5\e\Regressions\coreclr\GitHub_34094\Test34094\Test34094.cmd
Expected: True
Actual:   False


Stack trace
   at Regressions_coreclr._GitHub_34094_Test34094_Test34094_._GitHub_34094_Test34094_Test34094_cmd()

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run: runtime-coreclr jitstress 20210814.1

Failed test:

CoreCLR windows x86 Checked jitstress2 @ Windows.10.Amd64.Open
- Regressions\\coreclr\\GitHub_34094\\Test34094\\Test34094.cmd

CoreCLR OSX x64 Checked jitstress2 @ OSX.1013.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

CoreCLR Linux x64 Checked jitstress2 @ Ubuntu.1804.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

CoreCLR OSX x64 Checked jitstress1 @ OSX.1013.Amd64.Open
- Regressions/coreclr/GitHub_34094/Test34094/Test34094.sh

One of error message:

Assert failure(PID 5988 [0x00001764], Thread: 3976 [0x0f88]): Assertion failed '(emitChkAlign == false) || (ins == INS_lea) || ((emitComp->compCodeOpt() == Compiler::SMALL_CODE) && (((size_t)addr & 3) == 0)) || (((size_t)addr & (byteSize - 1)) == 0)' in 'Test34094:TestAvxCompareGreaterThanOrEqualDouble():bool' during 'Emit code' (IL size 270)

File: D:\workspace\_work\1\s\src\coreclr\jit\emitxarch.cpp Line: 11534
Image: C:\h\w\9FF408CA\p\corerun.exe
Return code:      1
Raw output file:      C:\h\w\9FF408CA\w\A79708F5\uploads\Reports\Regressions.coreclr\GitHub_34094\Test34094\Test34094.output.txt
Raw output:
BEGIN EXECUTION
"C:\h\w\9FF408CA\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false" Test34094.dll
Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=C:\h\w\9FF408CA\p
C:\h\w\9FF408CA\w\A79708F5\e\Regressions\coreclr\GitHub_34094\Test34094\Test34094.cmd
Expected: True
Actual:   False


Stack trace
   at Regressions_coreclr._GitHub_34094_Test34094_Test34094_._GitHub_34094_Test34094_Test34094_cmd()

Author:	VincentBu
Assignees:	-
Labels:	arch-x86, os-linux, os-windows, JitStress, arch-x64, area-CodeGen-coreclr, untriaged
Milestone:	-

[JulieLeeMSFT]

CC @dotnet/jit-contrib

[kunalspathak]

I spent some time investigating. It seems that we do not properly propagate the sizeAttr of some HW instrinsic instructions because of which we think that we want a specific alignment which is different than the actual alignment. E.g. , in the test for INS_vinsertf128 which operates on 16 bytes data but we initialize id->_idOpSize == 32 and never adjust it like

runtime/src/coreclr/jit/emitxarch.cpp

Lines 8789 to 8835 in 2144431

	switch (ins)
	{
	case INS_vextractf128:
	case INS_vextracti128:
	case INS_vinsertf128:
	case INS_vinserti128:
	{
	sizeAttr = EA_16BYTE;
	break;
	}
	case INS_pextrb:
	case INS_pinsrb:
	{
	sizeAttr = EA_1BYTE;
	break;
	}
	case INS_pextrw:
	case INS_pextrw_sse41:
	case INS_pinsrw:
	{
	sizeAttr = EA_2BYTE;
	break;
	}
	case INS_extractps:
	case INS_insertps:
	case INS_pextrd:
	case INS_pinsrd:
	{
	sizeAttr = EA_4BYTE;
	break;
	}
	case INS_pextrq:
	case INS_pinsrq:
	{
	sizeAttr = EA_8BYTE;
	break;
	}
	default:
	{
	break;
	}
	}

It is surprising that we didn't change anything recently in this area and we are seeing this issue now although it might be always there. The fix might need inspecting the code paths that are impacted by this (it may be that only DEBUG / asserts are impacted) and then coming up with some common method that assigns right attrSize for these instructions.

I would like to mark this as .NET 7 (since the issue is there for a while) and continue investigating and submit a fix.

Need to reenable the test that was disabled in #57473