Assertion failure while crossgenning ImageSharp: '!op1->TypeIs(TYP_STRUCT) && (op1->TypeGet() == op2->TypeGet())' in 'SixLabors.ImageSharp.PixelFormats.Byte4:ToString():System.String:this' during 'Morph - Global'

[jakobbotsch]

When crossgenning ImageSharp on current main I hit the following assertion:

C:\dev\dotnet\runtime2\src\coreclr\jit\simd.cpp:1646
Assertion failed '!op1->TypeIs(TYP_STRUCT) && (op1->TypeGet() == op2->TypeGet())' in 'SixLabors.ImageSharp.PixelFormats.Byte4:ToString():System.String:this' during 'Morph - Global' (IL size 85; hash 0xaeeb505c; FullOpts)

Small x64 repro (does not require crossgen, requires opts enabled/TC disabled):

using System;
using System.Numerics;
using System.Runtime.CompilerServices;

public class Program
{
    public static void Main(string[] args)
    {
        Byte4 foo = default;
        Console.WriteLine(foo.ToString());
    }
}

public partial struct Byte4
{
    public uint PackedValue { get; set; }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    public readonly Vector4 ToVector4() => new(
            this.PackedValue & 0xFF,
            (this.PackedValue >> 0x8) & 0xFF,
            (this.PackedValue >> 0x10) & 0xFF,
            (this.PackedValue >> 0x18) & 0xFF);

    public override readonly string ToString()
    {
        var vector = this.ToVector4();
        return FormattableString.Invariant($"Byte4({vector.X:#0.##}, {vector.Y:#0.##}, {vector.Z:#0.##}, {vector.W:#0.##})");
    }
}

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

When crossgenning ImageSharp on current main I hit the following assertion:

C:\dev\dotnet\runtime2\src\coreclr\jit\simd.cpp:1646
Assertion failed '!op1->TypeIs(TYP_STRUCT) && (op1->TypeGet() == op2->TypeGet())' in 'SixLabors.ImageSharp.PixelFormats.Byte4:ToString():System.String:this' during 'Morph - Global' (IL size 85; hash 0xaeeb505c; FullOpts)

Small repro (does not require crossgen):

using System;
using System.Numerics;
using System.Runtime.CompilerServices;

public class Program
{
    public static void Main(string[] args)
    {
        Byte4 foo = default;
        Console.WriteLine(foo.ToString());
    }
}

public partial struct Byte4
{
    public uint PackedValue { get; set; }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    public readonly Vector4 ToVector4() => new(
            this.PackedValue & 0xFF,
            (this.PackedValue >> 0x8) & 0xFF,
            (this.PackedValue >> 0x10) & 0xFF,
            (this.PackedValue >> 0x18) & 0xFF);

    public override readonly string ToString()
    {
        var vector = this.ToVector4();
        return FormattableString.Invariant($"Byte4({vector.X:#0.##}, {vector.Y:#0.##}, {vector.Z:#0.##}, {vector.W:#0.##})");
    }
}

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[SingleAccretion]

Likely a regression from #69917.

Will take a look.