Bad test input in `UpgradeToRegexGeneratorAnalyzerTests`

[Youssef1313]

Description

runtime/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs

Line 48 in 671fe42

var regex = new Regex("""", timeout: TimeSpan.FromSeconds(10));

runtime/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs

Line 59 in 671fe42

var regex = new Regex(timeout: TimeSpan.FromSeconds(10), pattern: """");

None of the constructors has a "timeout" parameter. I believe the test wanted to refer to this constructor, but the parameter was misspelled. I'm not sure though if the lack of options parameter is an intentional error scenario to test.

public Regex (string pattern, System.Text.RegularExpressions.RegexOptions options, TimeSpan matchTimeout);

@joperezr What was the intention here?

I discovered this while enabling validation of compiler diagnostics in tests.

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

runtime/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs

Line 48 in 671fe42

var regex = new Regex("""", timeout: TimeSpan.FromSeconds(10));

runtime/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToRegexGeneratorAnalyzerTests.cs

Line 59 in 671fe42

var regex = new Regex(timeout: TimeSpan.FromSeconds(10), pattern: """");

None of the constructors has a "timeout" parameter. I believe the test wanted to refer to this constructor, but the parameter was misspelled. I'm not sure though if the lack of options parameter is an intentional error scenario to test.

public Regex (string pattern, System.Text.RegularExpressions.RegexOptions options, TimeSpan matchTimeout);

@joperezr What was the intention here?

I discovered this while enabling validation of compiler diagnostics in tests.

Reproduction Steps

Expected behavior

Actual behavior

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	Youssef1313
Assignees:	-
Labels:	area-System.Text.RegularExpressions
Milestone:	-

[Youssef1313]

After determining the tests intention, Youssef1313@37753ea could be cherry-picked to ensure we verify diagnostics for tests.

[joperezr]

thanks for catching the issue with the misspelling of the parameter, that was indeed not intended. As for the missing options, that was also not intended. It would be great to cherry-pick from your PR 😄