JIT: Widespread jitstress failures with "Assertion failed 'node->OperIsLIR()'"

[jakobbotsch]

E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=483238&view=results

05:32:58.596 Running test: JIT/Directed/cmov/Bool_And_Op_cs_d/Bool_And_Op_cs_d.dll

Assert failure(PID 24 [0x00000018], Thread: 24 [0x0018]): Assertion failed 'node->OperIsLIR()' in 'testout1:Sub_Funclet_1():int' during 'Rationalize IR' (IL size 527; hash 0x96161c08; MinOpts)

    File: /__w/1/s/src/coreclr/jit/lir.cpp Line: 1616
    Image: /root/helix/work/correlation/corerun

{
  "ErrorMessage": "Assertion failed 'node->OperIsLIR()'",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Introduced/exposed by #95249, cc @EgorBo

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=483238
Error message validated: Assertion failed 'node->OperIsLIR()'
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 11/29/2023 9:46:24 AM UTC

Report

Build	Definition	Test	Pull Request
484631	dotnet/runtime	System.Globalization.Extensions.Tests.WorkItemExecution
483315	dotnet/runtime	System.Globalization.Extensions.Tests.WorkItemExecution
483238	dotnet/runtime	GC\Scenarios\DoublinkList\dlbigleakthd\dlbigleakthd.cmd
482941	dotnet/runtime	GC\API\NoGCRegion\Callback_Svr\Callback_Svr.cmd	#95326

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
1	4	4

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=483238&view=results

05:32:58.596 Running test: JIT/Directed/cmov/Bool_And_Op_cs_d/Bool_And_Op_cs_d.dll

Assert failure(PID 24 [0x00000018], Thread: 24 [0x0018]): Assertion failed 'node->OperIsLIR()' in 'testout1:Sub_Funclet_1():int' during 'Rationalize IR' (IL size 527; hash 0x96161c08; MinOpts)

    File: /__w/1/s/src/coreclr/jit/lir.cpp Line: 1616
    Image: /root/helix/work/correlation/corerun

{
  "ErrorMessage": "Assertion failed 'node->OperIsLIR()'",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Introduced/exposed by #95249, cc @EgorBo

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr, untriaged, blocking-clean-ci-optional
Milestone:	-

[EgorBo]

Oops, I should run more outerloops on my PRs 😞

This one is already fixed in #95353

the assert happens because we encounter a GT_NOP of type TYP_LONG in LIR and it's produced by fgStress64RsltMulCB (tree->AsOp()->gtOp1 = pComp->gtNewOperNode(GT_NOP, TYP_LONG, tree->AsOp()->gtOp1);)

[EgorBo]

Fixed by #95353