[mono][marshal] Assertion should not be reached in mono_marshal_shared_conv_to_icall

[lambdageek]

Error Blob

{
  "ErrorMessage": "Assertion: should not be reached at /__w/1/s/src/mono/mono/metadata/marshal-shared.c:471",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": true
}

Reproduction Steps

No response

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=560509&view=logs&j=d25dc2c0-518b-5583-f661-5ac905106679&t=47cb0142-4d6b-5edf-a0a8-cf81fa3f7e05
Result validation: ⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.
Validation performed at: 2/12/2024 4:58:51 PM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
564149	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log
563637	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log	#98320
563468	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log
562296	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log
562067	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log
562000	dotnet/runtime	LLVM AOT cross-compile CoreCLR tests	Log	#98279
560509	dotnet/runtime	LLVM AOT compile CoreCLR tests	Log	#92057

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
2	7	7

Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Assertion: should not be reached at /__w/1/s/src/mono/mono/metadata/marshal-shared.c:471",
  "ExcludeConsoleLog": true
}

Reproduction Steps

No response

Known issue validation

Build: 🔎
Result validation: ⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.
Validation performed at: 2/12/2024 4:58:49 PM UTC

Author:	lambdageek
Assignees:	-
Labels:	area-System.ComponentModel.DataAnnotations, blocking-clean-ci, Known Build Error
Milestone:	-

[lambdageek]

Breaking when the AOT compiler is compiling these two tests:

aot-compile: compiling /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop/AnsiBStrTest.dll; MONO_PATH: /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop:/__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Tests/Core_Root
  Mono Ahead of Time compiler - compiling assembly /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop/AnsiBStrTest.dll

and

aot-compile: compiling /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop/BSTRTest.dll; MONO_PATH: /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop:/__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Tests/Core_Root
  Mono Ahead of Time compiler - compiling assembly /__w/1/s/artifacts/tests/coreclr/linux.x64.Release/Interop/Interop/BSTRTest.dll
  AOTID AD838859-9056-1E7A-B96E-AD46B2CD0FAD
  * Assertion: should not be reached at /__w/1/s/src/mono/mono/metadata/marshal-shared.c:471

[lambdageek]

@jkoritzinsky probably we removed too much COM interop?

[jkoritzinsky]

If it's just the BStr tests, than I probably removed some BStr case that was connected to the COM stuff. Alternatively, it might be some COM path where we need to bail out more cleanly.

In any case, I'll take a look.

[lambdageek]

We just started running the LLVM aot runtime tests again after the recent slate of PRs to make the LLVM compilation use less memory, so this was probably missed because the tests didn't run on the COM PR yet

[lambdageek]

I guess it's in this PR: #92057

[lambdageek]

Actually I take it back. it's failing in runtime-extra-platforms on other main, too:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=562296&view=results

https://dev.azure.com/dnceng-public/public/_build/results?buildId=562296&view=logs&j=d25dc2c0-518b-5583-f661-5ac905106679&t=47cb0142-4d6b-5edf-a0a8-cf81fa3f7e05&l=1453