Adding Activity.AddException - #102905
Merged
Merged
Conversation
ghost
added
|
Note regarding the |
Member
Author
stephentoub
reviewed
May 31, 2024
cijothomas
reviewed
May 31, 2024
skyoxZ
reviewed
May 31, 2024
CodeBlanch
reviewed
Jun 3, 2024
| /// <para>- Any registered <see cref="ActivityListener"/> with the <see cref="ActivityListener.ExceptionRecorder"/> callback that adds "exception.message", "exception.stacktrace", or "exception.type" tags | ||
| /// will not have these tags overwritten, except by any subsequent <see cref="ActivityListener"/> that explicitly overwrites them.</para> | ||
| /// </remarks> | ||
| public Activity AddException(Exception exception, TagList tags = default, DateTimeOffset timestamp = default) |
Contributor
There was a problem hiding this comment.
@tarekgh Sorry just noticed this but should we use in TagList tags here? It is kind of big struct that might save some copy cycles.
Member
There was a problem hiding this comment.
I wouldn't be too worried either way. Presumably to get to this point the dev already threw and caught an Exception costing them 10s of microseconds. Spending an extra 10? nanoseconds copying a struct seems neglible.
Member
Author
There was a problem hiding this comment.
I already opened a PR #103009 for it.
The other point is we always pass TagList by ref in other APIs. Consistency is good beside getting minor perf is not bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #53641