Fix retry loop around Process.Kill

[jkotas]

We do not need to be retrying after Process.Kill succeeds

[jkotas]

Missed a change in #102958

[skyoxZ]

Should it throw if all tries fail?

[danmoseley]

Oh wow, who code reviewed that!

[jkotas]

Should it throw if all tries fail?

The tests should still work fine if the process that we tried to kill does not get actually killed in rare situations. It will increase memory load on the test machine.

This workaround should not be needed in the first place. It is working around bugs in Process.Kill implementation.

[skyoxZ]

The tests should still work fine if the process that we tried to kill does not get actually killed in rare situations.

But how could we know it's a rare situation if it doesn't throw? Maybe all these 4 retries will 100% fail.

[jkotas]

Ok, I have made the change to propagate the exception from the last retry: #102974 . It is going to tell us whether the failure is persistent once it occurs that is a useful data point.