Skip to content

Fix some NRT on StringCollection #106116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Sep 5, 2024
Merged

Fix some NRT on StringCollection #106116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f777f3
Fix some NRT on StringCollections
lilinus Aug 8, 2024
ce67517
Merge branch 'main' into fix-stringcollection-nrt
eiriktsarpalis Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Collections.Specialized/ref/System.Collections.Specialized.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,10 @@ public StringCollection() { }
bool System.Collections.IList.IsReadOnly { get { throw null; } }
object? System.Collections.IList.this[int index] { get { throw null; } set { } }
public int Add(string? value) { throw null; }
public void AddRange(string[] value) { }
public void AddRange(string?[] value) { }
public void Clear() { }
public bool Contains(string? value) { throw null; }
public void CopyTo(string[] array, int index) { }
public void CopyTo(string?[] array, int index) { }
public System.Collections.Specialized.StringEnumerator GetEnumerator() { throw null; }
public int IndexOf(string? value) { throw null; }
public void Insert(int index, string? value) { }
Expand Down
4 changes: 2 additions & 2 deletions ...ies/System.Collections.Specialized/src/System/Collections/Specialized/StringCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public int Add(string? value)
/// <devdoc>
/// <para>Copies the elements of a string array to the end of the <see cref='System.Collections.Specialized.StringCollection'/>.</para>
/// </devdoc>
public void AddRange(string[] value)
public void AddRange(string?[] value)
{
ArgumentNullException.ThrowIfNull(value);

Expand Down Expand Up @@ -99,7 +99,7 @@ public bool Contains(string? value)
/// <para>Copies the <see cref='System.Collections.Specialized.StringCollection'/> values to a one-dimensional <see cref='System.Array'/> instance at the
/// specified index.</para>
/// </devdoc>
public void CopyTo(string[] array, int index)
public void CopyTo(string?[] array, int index)
{
data.CopyTo(array, index);
}
Expand Down