Fix build with -DCLR_CMAKE_USE_SYSTEM_BROTLI=true - #110816
Conversation
88f19ab to
5e42b11
Compare
| find_library(BROTLIDEC brotlidec REQUIRED) | ||
| find_library(BROTLIENC brotlienc REQUIRED) |
There was a problem hiding this comment.
Can we move these into Compression.Native/CMakeLists.txt and add the two libraries to the BROTLI_LIBRARIES variable? That would keep all of the brotli handling together.
There was a problem hiding this comment.
Does the updated change look okay?
There was a problem hiding this comment.
Wait, this doesn't work at all :(
There was a problem hiding this comment.
Ah, because src/native/corehost/apphost/static/CMakeLists.txt only includes NATIVE_LIBS
runtime/src/native/corehost/apphost/static/CMakeLists.txt
Lines 183 to 185 in d7e85d9
Should it include BROTLI_LIBRARIES under a CLR_CMAKE_USE_SYSTEM_BROTL conditional?
There was a problem hiding this comment.
The BROTLI_LIBRARIES values should be propagated up to the static apphost due to
and
You can change it back to how it was before to unblock and I can investigate later.
5e42b11 to
aa6a70b
Compare
Currently, this fails on Fedora 41:
$ ./build.sh --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=true /p:FullAssemblySigningSupported=false
...
[100%] Linking CXX executable singlefilehost
ld.lld: error: undefined symbol: BrotliDecoderCreateInstance
>>> referenced by entrypoints.c
>>> entrypoints.c.o:(s_compressionNative) in archive ../libs-native/System.IO.Compression.Native/libSystem.IO.Compression.Native.a
This seems to be a regression introduced when this bit was accidentally
dropped:
https://github.com/dotnet/runtime/pull/109707/files#diff-7a160e52815fdd808d9415ada41dd5b1748826b27c78277e14f4adcf1ce61511
Fix the build by re-introducing it.
Fixes: dotnet#110751
aa6a70b to
6acd94c
Compare
Currently, this fails on Fedora 41:
This seems to be a regression introduced when this bit was accidentally dropped:
https://github.com/dotnet/runtime/pull/109707/files#diff-7a160e52815fdd808d9415ada41dd5b1748826b27c78277e14f4adcf1ce61511
Fix the build by re-introducing it.
Fixes: #110751