JIT: move second pass of EH opts earlier - #111364
Merged
Merged
Conversation
to avoid messing up loop exit canonicalization (which is sensitive to loops with internal EH flow). Fixed dotnet#110959. Also, remove some of the ceremony around `fgModified` -- seems like this is no longer useful/needed. Defer deciding if we need a PSPSym until we create funclets. This removes unused PSPSym allocations in some cases. Also, there is no benefit to tracking the PSPSym, so stop doing that.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@jakobbotsch PTAL Some diffs expected. Mostly less PSPSym, but a few cases where we now unroll loops as EH was removed, and a few where not tracking PSPSym alters allocation. |
BruceForstall
approved these changes
Jan 13, 2025
Member
Author
|
Looks like we often also decide too early that we need a stack frame, will need to look into that someday. |
Member
Author
|
CI seems to be taking a long time to spin up. |
jakobbotsch
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid messing up loop exit canonicalization (which is sensitive to loops with internal EH flow).
Fixes #110959.
Also, remove some of the ceremony around
fgModified-- seems like this is no longer useful/needed.Defer deciding if we need a PSPSym until we create funclets. This removes unused PSPSym allocations in some cases. Also, there is no benefit to tracking the PSPSym, so stop doing that.