Skip to content

JIT: Skip validation of debug info mappings in optimized codegen #112942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Feb 26, 2025
Merged

JIT: Skip validation of debug info mappings in optimized codegen #112942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/tests/JIT/Directed/debugging/debuginfo/tester.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@
<GCStressIncompatible>true</GCStressIncompatible>
</PropertyGroup>
<ItemGroup>
<!-- These expectedly interfere with debug info -->
<CLRTestEnvironmentVariable Include="DOTNET_JitNoForwardSub" Value="1" />
<CLRTestEnvironmentVariable Include="DOTNET_JitEnableHeadTailMerge" Value="0" />
<CLRTestEnvironmentVariable Include="DOTNET_JitEnableCrossBlockLocalAssertionProp" Value="0" />
<CLRTestEnvironmentVariable Include="DOTNET_JitEnableOptRepeat" Value="0" />

<ProjectReference Include="tests_d.ilproj" Aliases="tests_d" />
<ProjectReference Include="tests_r.ilproj" Aliases="tests_r" />
<ProjectReference Include="attribute.csproj" />
Expand Down
6 changes: 3 additions & 3 deletions src/tests/JIT/Directed/debugging/debuginfo/tests.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
{
.custom instance void [attribute]ExpectedILMappings::.ctor() = {
property int32[] Debug = int32[2]( 0 6 )
property int32[] Opts = int32[2]( 0 6 )
property int32[] Opts = int32[0]( )
}
.maxstack 8
IL_0000: call int32 DebugInfoMethods::NeverInlined()
Expand All @@ -59,7 +59,7 @@
{
.custom instance void [attribute]ExpectedILMappings::.ctor() = {
property int32[] Debug = int32[2]( 0 6 )
property int32[] Opts = int32[2]( 0 0xE )
property int32[] Opts = int32[0]( )
}
.maxstack 2
.locals init (int32 V_0)
Expand Down Expand Up @@ -99,7 +99,7 @@
// as this is used for the managed-ret-val feature, but the debugger filters out these mappings and does not
// report them in the ETW event. We should probably change this, those mappings should be useful in any case.
property int32[] Debug = int32[10]( 0x0 0x6 0xe 0x12 0x1a 0x1c 0x24 0x28 0x2c 0x34 )
property int32[] Opts = int32[6]( 0x0 0x6 0xe 0x12 0x1c 0x2c )
property int32[] Opts = int32[0]( )
}
.maxstack 2
.locals init (int32 V_0)
Expand Down