Skip to content

JIT: remove single-def restriction from escape analysis type refinement #113808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 3 commits into from
Mar 25, 2025
Merged

JIT: remove single-def restriction from escape analysis type refinement #113808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
042c215
JIT: remove single-def restriction from escape analysis type refinement
AndyAyersMS Mar 18, 2025
6529f63
Merge branch 'main' into ObjAllocRemoveSingleDefRestrictionOnRefinement
AndyAyersMS Mar 25, 2025
85c1f67
fix post-merge build error; review feedback
AndyAyersMS Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7291,6 +7291,7 @@ bool GenTree::OperSupportsOrderingSideEffect() const

switch (OperGet())
{
case GT_ARR_ADDR:
case GT_BOUNDS_CHECK:
case GT_IND:
case GT_BLK:
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/jit/gentree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ enum GenTreeFlags : unsigned int
GTF_VAR_MOREUSES = 0x00800000, // GT_LCL_VAR -- this node has additional uses, for example due to cloning
GTF_VAR_CONTEXT = 0x00400000, // GT_LCL_VAR -- this node is part of a runtime lookup
GTF_VAR_EXPLICIT_INIT = 0x00200000, // GT_LCL_VAR -- this node is an "explicit init" store. Valid until rationalization.
GTF_VAR_CONNECTED = 0x00100000, // GT_STORE_LCL_VAR -- this store was modelled in the connection graph during escape analysis

// For additional flags for GT_CALL node see GTF_CALL_M_*

Expand Down
10 changes: 7 additions & 3 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3181,17 +3181,21 @@ GenTree* Compiler::fgMorphIndexAddr(GenTreeIndexAddr* indexAddr)
}
#endif

// Note the array reference may now be TYP_I_IMPL, TYP_BYREF, or TYP_REF
//
var_types const arrPtrType = arrRef->TypeIs(TYP_I_IMPL) ? TYP_I_IMPL : TYP_BYREF;

// First element's offset
GenTree* elemOffset = gtNewIconNode(elemOffs, TYP_I_IMPL);
if (groupArrayRefWithElemOffset)
{
GenTree* basePlusOffset = gtNewOperNode(GT_ADD, TYP_BYREF, arrRef, elemOffset);
addr = gtNewOperNode(GT_ADD, TYP_BYREF, basePlusOffset, addr);
GenTree* basePlusOffset = gtNewOperNode(GT_ADD, arrPtrType, arrRef, elemOffset);
addr = gtNewOperNode(GT_ADD, arrPtrType, basePlusOffset, addr);
}
else
{
addr = gtNewOperNode(GT_ADD, TYP_I_IMPL, addr, elemOffset);
addr = gtNewOperNode(GT_ADD, TYP_BYREF, arrRef, addr);
addr = gtNewOperNode(GT_ADD, arrPtrType, arrRef, addr);
}

// TODO-Throughput: bash the INDEX_ADDR to ARR_ADDR here instead of creating a new node.
Expand Down
Loading
Loading