Skip to content

Replace compiler specific options with C++ thread_local keyword - #114660

Merged
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:thread_local_pal
Apr 19, 2025
Merged

Replace compiler specific options with C++ thread_local keyword#114660
AaronRobinsonMSFT merged 5 commits into
dotnet:mainfrom
AaronRobinsonMSFT:thread_local_pal

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT commented Apr 14, 2025

Copy link
Copy Markdown
Member

Rename gCurrentThreadInfo to t_CurrentThreadInfo to align with the naming convention.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Apr 14, 2025
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

/cc @jkotas @janvorli

@dotnet-policy-service

dotnet-policy-service Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas

jkotas commented Apr 15, 2025

Copy link
Copy Markdown
Member

Build breaks look related:

 _t_ThreadStatics, referenced from:
        _GetThreadVarsAddress in asmhelpers.S.o
        _GetThreadVarsAddress in asmhelpers.S.o

jkotas
jkotas reviewed Apr 15, 2025
View reviewed changes
Comment thread src/coreclr/vm/jithelpers.cpp Outdated
@build-analysis build-analysis Bot mentioned this pull request Apr 15, 2025
Open
3 tasks
@AaronRobinsonMSFT
AaronRobinsonMSFT marked this pull request as ready for review April 15, 2025 18:58
@build-analysis build-analysis Bot mentioned this pull request Apr 15, 2025
Open
3 tasks
jkotas
jkotas approved these changes Apr 16, 2025
View reviewed changes
Comment thread src/coreclr/vm/jithelpers.cpp Outdated
Comment thread src/coreclr/vm/threadstatics.h Outdated
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 55b8f9f into dotnet:main Apr 19, 2025
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the thread_local_pal branch April 19, 2025 03:42
This was referenced Apr 24, 2025
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-VM-coreclr

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AaronRobinsonMSFT @jkotas