Skip to content

Interpreter shared generics support #116357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwrighton merged 8 commits into from
Jun 9, 2025
Merged

Interpreter shared generics support #116357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2afdb8f
Step 1 in shared generics
davidwrighton Jun 3, 2025
1b76ff1
Implement newobj for normal classes and structs
davidwrighton Jun 5, 2025
b47739f
Merge branch 'main' of https://github.com/dotnet/runtime
davidwrighton Jun 5, 2025
b5f3cbc
Pass all the tests, and add some more
davidwrighton Jun 6, 2025
3016e59
Fix build breaks due to extra field in MethodDesc
davidwrighton Jun 6, 2025
21b0b47
Fix factoring and naming of generic lookups
davidwrighton Jun 6, 2025
d475b98
Attempt to fix build issues and code review comments
davidwrighton Jun 6, 2025
017362b
Improve factoring
davidwrighton Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/inc/corinfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ enum CORINFO_CALLINFO_FLAGS
CORINFO_CALLINFO_ALLOWINSTPARAM = 0x0001, // Can the compiler generate code to pass an instantiation parameters? Simple compilers should not use this flag
CORINFO_CALLINFO_CALLVIRT = 0x0002, // Is it a virtual call?
// UNUSED = 0x0004,
// UNUSED = 0x0008,
CORINFO_CALLINFO_DISALLOW_STUB = 0x0008, // Do not use a stub for this call, even if it is a virtual call.

@jkotas jkotas Jun 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add this to the managed view as well.

@davidwrighton davidwrighton Jun 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this in a followup pr

CORINFO_CALLINFO_SECURITYCHECKS = 0x0010, // Perform security checks.
CORINFO_CALLINFO_LDFTN = 0x0020, // Resolving target of LDFTN
// UNUSED = 0x0040,
Expand Down
Loading