Skip to content

Fix benchmarksgame tests to be able to resolve the embedded resources #118605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 1 commit into from
Aug 12, 2025
Merged

Fix benchmarksgame tests to be able to resolve the embedded resources #118605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tests/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/harness-helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ public TestHarnessHelpers(bool bigInput, [System.Runtime.CompilerServices.Caller
expectedCountLetter = new int[] { 302923, 301375, 198136, 197566 };
expectedCountPairs = new int[] { 91779, 91253, 91225, 90837, 60096, 60030, 59889, 59795, 59756, 59713, 59572, 59557, 39203, 39190, 39081, 39023 };
expectedCountFragments = new int[] { 11765, 3572, 380, 7, 7 };
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.knucleotide-input-big.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.knucleotide-input-big.txt";
}
else
{
expectedCountLetter = new int[] { 1576, 1480, 974, 970 };
expectedCountPairs = new int[] { 496, 480, 470, 420, 316, 315, 310, 302, 298, 292, 273, 272, 202, 201, 185, 167 };
expectedCountFragments = new int[] { 54, 24, 4, 0, 0 };
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.knucleotide-input.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.knucleotide-input.txt";
}
expectedFrequencies = new int[][] { expectedCountLetter, expectedCountPairs };
}
Expand Down
1 change: 0 additions & 1 deletion src/tests/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/k-nucleotide-1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public class KNucleotide_1
{

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
1 change: 0 additions & 1 deletion src/tests/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/k-nucleotide-9.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ static string writeCount(Dictionary<long, Wrapper> dictionary, string fragment,
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
4 changes: 2 additions & 2 deletions src/tests/JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/harness-helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ public TestHarnessHelpers(bool bigInput, [System.Runtime.CompilerServices.Caller
if (bigInput)
{
ExpectedLength = 136381;
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.regexdna-input25000.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.regexdna-input25000.txt";
}
else
{
ExpectedLength = 152;
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.regexdna-input25.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.regexdna-input25.txt";
}
}

Expand Down
1 change: 0 additions & 1 deletion src/tests/JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ namespace BenchmarksGame
public class RegexRedux_1
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
3 changes: 1 addition & 2 deletions src/tests/JIT/Performance/CodeQuality/BenchmarksGame/regex-redux/regex-redux-5.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

/* The Computer Language Benchmarks Game
http://benchmarksgame.alioth.debian.org/

Regex-Redux by Josh Goldfoot
order variants by execution time by Anthony Lloyd
*/
Expand Down Expand Up @@ -38,7 +38,6 @@ static string regexCount(string s, string r)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
4 changes: 2 additions & 2 deletions src/tests/JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/harness-helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ public TestHarnessHelpers(bool bigInput, [System.Runtime.CompilerServices.Caller
{
FileLength = 254245;
CheckSum = "61-A4-CC-6D-15-8D-26-77-88-93-4F-E2-29-A2-8D-FB";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.revcomp-input25000.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.revcomp-input25000.txt";
}
else
{
FileLength = 333;
CheckSum = "62-45-8E-09-2E-89-A0-69-8C-17-F5-D8-C7-63-5B-50";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName)}.revcomp-input25.txt";
resourceName = $"{Path.GetFileNameWithoutExtension(csFileName).Replace('-', '_')}.revcomp-input25.txt";
}
}

Expand Down
1 change: 0 additions & 1 deletion ...sts/JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/reverse-complement-1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ struct Index
const byte Lf = (byte)'\n';

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
1 change: 0 additions & 1 deletion ...sts/JIT/Performance/CodeQuality/BenchmarksGame/reverse-complement/reverse-complement-6.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ static void Writer()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/118475")]
public static int TestEntryPoint()
{
var helpers = new TestHarnessHelpers(bigInput: false);
Expand Down
Loading