[release/10.0] [mono][aot] Avoid use of local buffer that could overflow - #119202
Merged
Conversation
github-actions
Bot
requested review from
steveisok and
vitek-karas
as code owners
August 29, 2025 11:14
BrzVlad
approved these changes
Aug 29, 2025
vitek-karas
approved these changes
Aug 29, 2025
jeffschwMSFT
approved these changes
Aug 29, 2025
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
This was referenced Aug 29, 2025
Open
Member
|
@BrzVlad please take a look at the ci failures |
Member
|
/ba-g LLVM Failure is known and tracked. Not sure why build analysis didn't update correctly. |
steveisok
enabled auto-merge (squash)
September 4, 2025 10:54
jeffschwMSFT
disabled auto-merge
September 4, 2025 16:13
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #118985 to release/10.0
/cc @BrzVlad
Customer Impact
Maui application can fail to build due to crash in the aot compiler. This would happen if some symbol is too long, which could happen more commonly if special characters are involved in the application, since they have longer encoding.
Regression
Testing
Tested locally with repro project.
Risk
Low. The fix is trivial, it just removes indirection through a buffer that was hardcoded in size.