[release/10.0] Use DllImportSearchPath.AssemblyDirectory for loading jitinterface library - #119333
Merged
Merged
Conversation
MichalStrehovsky
approved these changes
Sep 3, 2025
jeffschwMSFT
approved these changes
Sep 3, 2025
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we can merge when ready
jeffschwMSFT
added
Servicing-approved
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
elinor-fung
removed
Servicing-approved
elinor-fung
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #119287 to release/10.0
/cc @elinor-fung
Customer Impact
Issue: #118999
Publishing a NativeAOT project on Unix with
IlcInstructionSet=nativefails.When loading the jitinterface library on Unix,
ilc(native AOT app) was relying on the application path being part of the default OS search. With the removal of the default RPATH for native AOT binaries, this is no longer the case. The code doing the loading was usingDllImportSearchPath.ApplicationDirectory, which has no meaning on non-Windows.DllImportSearchPath.AssemblyDirectoryis the only flag respected - and for native AOT, would look next to the application.Regression
.NET 10 Preview 6: #115236
Testing
Manual verification.
Risk
Low. Fix is targeted.