Baseline failing async tests#121761
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR baselines failing async tests for NativeAOT compatibility by working around unsupported features. The changes address three main issues: the dynamic keyword is unsupported in NativeAOT, AssemblyLoadContext (ALC) collectible assemblies are not supported, and the GetInterfaceMap API has known issues that will cause test failures.
- Replaced
dynamickeyword usage with conditional reflection-based invocation for NativeAOT - Disabled
GetInterfaceMaptest on NativeAOT using[ActiveIssue]attribute - Converted collectible ALC test to conditional test that skips when collectible assemblies are not supported
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/async/reflection/reflection-simple.cs | Adds NativeAOT workaround for dynamic keyword usage by using reflection when running on NativeAOT, and disables GetInterfaceMap test on NativeAOT with ActiveIssue attribute |
| src/tests/async/collectible-alc/collectible-alc.csproj | Adds TestLibrary project reference needed for PlatformDetection API |
| src/tests/async/collectible-alc/collectible-alc.cs | Converts test to ConditionalFact that skips when collectible assemblies are not supported (NativeAOT) |
Member
Author
|
/ba-g osx legs didn't run due to brownout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dynamickeyword is unsupported with AOTGetInterfaceMapAPI has known issues (the test actually passes right now, but will fail with Build the test tree with TrimMode=full #121697 so just disabling now)Cc @dotnet/ilc-contrib