[release/8.0-staging] Update dependencies from dotnet/xharness#124544
[release/8.0-staging] Update dependencies from dotnet/xharness#124544dotnet-maestro[bot] wants to merge 12 commits intorelease/8.0-stagingfrom
Conversation
…60217.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.25516.2 -> To Version 11.0.0-prerelease.26117.1
…fbbd-11e1-401a-8331-1b09b331aef6
…fbbd-11e1-401a-8331-1b09b331aef6
…fbbd-11e1-401a-8331-1b09b331aef6
is this related @kotlarmilos @pavelsavara ? |
|
Yes, fix is coming in dotnet/xharness#1572 |
…60317.2 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.25516.2 -> To Version 11.0.0-prerelease.26167.2
…60318.1 On relative base path root Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.25516.2 -> To Version 11.0.0-prerelease.26168.1
…fbbd-11e1-401a-8331-1b09b331aef6
XHarness.Common 11.0.0-prerelease.26168.1 transitively requires Microsoft.Extensions.Logging >= 8.0.1, causing NU1605 package downgrade errors against the pinned 6.0.0 version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Helix SDK 8.0.0-beta.26112.1 (from arcade release/8.0) defaults XHarnessTargetFramework to net7.0, but XHarness CLI 11.0.0-prerelease.26168.1 only ships net8.0+ TFMs. This causes 'Failed to install the dotnet tool' errors because dotnet tool install cannot find a net7.0 asset in the package. Override XHarnessTargetFramework to net8.0 in all locations that set IncludeXHarnessCli=true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
do you know if this comes from xharness or the test @kotlarmilos ??? cc: @pavelsavara |
@wfurt this CLI option didn't exist in Net8, see runtime/src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs Lines 99 to 102 in a9b578e runtime/src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs Lines 30 to 54 in 18a28bc |
|
where how should we fix it? If unrelated to updated Xharness, I can merge this PR, right? |
|
It is coming from xharness Easiets fix is to add the option processing into You can't merge this as is, it breaks all WASM tests |
The updated XHarness passes -verbosity to the WASM test runner, but SimpleWasmTestRunner on release/8.0-staging does not handle it, causing all WASM tests to fail with 'Invalid argument -verbosity'. Accept and skip the argument to prevent the crash. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Xharness now installs correctly
Added Should be ready for merge |
…fbbd-11e1-401a-8331-1b09b331aef6
|
@steveisok Please take a look |
|
Something duplicates |
The JSON message processor concatenated payload and arguments fields (payload + " " + arguments), but for simple console.log() calls both contain the same text. This produced duplicated output like 'WASM EXIT 0 WASM EXIT 0', and int.Parse on the substring threw FormatException, crashing the message processor with exit code 71. Use payload alone (fall back to arguments only when payload is null), and switch to int.TryParse for robustness. Fixes: dotnet/runtime#124544 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request updates the following dependencies
From https://github.com/dotnet/xharness