Conversation
…ignature Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…tCCWData from existing APIs Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…n GetCCWInterfaces Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement cDAC SosDac API GetCCWData
Implement cDAC SosDac API GetCCWData
Mar 7, 2026
…CCW APIs Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…Is; refactor all SCCW callers Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot
AI
changed the title
Implement cDAC SosDac API GetCCWData
cDAC BuiltInCOM: remove GetCCWData contract API, add GetSimpleComCallWrapper/GetSimpleComCallWrapperData, compose SoSDac from fine-grained APIs
Mar 10, 2026
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…omCallWrapperData; simplify all callers Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot
AI
changed the title
cDAC BuiltInCOM: remove GetCCWData contract API, add GetSimpleComCallWrapper/GetSimpleComCallWrapperData, compose SoSDac from fine-grained APIs
cDAC BuiltInCOM: add GetSimpleComCallWrapper/GetSimpleComCallWrapperData; remove individual predicate APIs
Mar 10, 2026
…ative enum; consolidate all SCCW data into GetSimpleComCallWrapperData Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot
AI
changed the title
cDAC BuiltInCOM: add GetSimpleComCallWrapper/GetSimpleComCallWrapperData; remove individual predicate APIs
cDAC BuiltInCOM: Consolidate SCCW data into GetSimpleComCallWrapperData; remove redundant predicate APIs
Mar 10, 2026
Removed duplicate RCWCleanupInfo struct definition and related comments.
max-charlamb
approved these changes
Mar 12, 2026
noahfalk
reviewed
Mar 13, 2026
Member
noahfalk
left a comment
There was a problem hiding this comment.
The code is fine but the PR description appears misleading, this PR is doing a lot more than just a contract API refactoring.
...managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/SimpleComCallWrapper.cs
Show resolved
Hide resolved
...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ComCallWrapper.cs
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Mar 19, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
/ba-g OSX and android timing out |
This was referenced Mar 20, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetSimpleComCallWrapperDatasupersedesGetRefCountandIsHandleWeak🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.