Skip to content

Add cDAC API GetCCWData#125288

Merged
rcj1 merged 24 commits intomainfrom
copilot/implement-getccwdata-api
Mar 20, 2026
Merged

Add cDAC API GetCCWData#125288
rcj1 merged 24 commits intomainfrom
copilot/implement-getccwdata-api

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 7, 2026

  • Adds cDAC SOS API GetCCWData
  • Adds following contract APIs:
// Returns the GC object handle from the given ComCallWrapper.
public TargetPointer GetObjectHandle(TargetPointer ccw);
// Returns the data stored in the SimpleComCallWrapper associated with the given ComCallWrapper.
public SimpleComCallWrapperData GetSimpleComCallWrapperData(TargetPointer ccw);
// Navigates to the start ComCallWrapper in a linked chain.
// If ccw is already the start wrapper (or the only wrapper), returns ccw unchanged.
public TargetPointer GetStartWrapper(TargetPointer ccw);

GetSimpleComCallWrapperData supersedes GetRefCount and IsHandleWeak


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 3 commits March 7, 2026 06:04
…ignature

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…tCCWData from existing APIs

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…n GetCCWInterfaces

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement cDAC SosDac API GetCCWData Implement cDAC SosDac API GetCCWData Mar 7, 2026
Copilot finished work on behalf of rcj1 March 7, 2026 06:21
…CCW APIs

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…Is; refactor all SCCW callers

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI changed the title Implement cDAC SosDac API GetCCWData cDAC BuiltInCOM: remove GetCCWData contract API, add GetSimpleComCallWrapper/GetSimpleComCallWrapperData, compose SoSDac from fine-grained APIs Mar 10, 2026
Copilot finished work on behalf of rcj1 March 10, 2026 05:26
Copilot AI and others added 2 commits March 10, 2026 05:36
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
…omCallWrapperData; simplify all callers

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI changed the title cDAC BuiltInCOM: remove GetCCWData contract API, add GetSimpleComCallWrapper/GetSimpleComCallWrapperData, compose SoSDac from fine-grained APIs cDAC BuiltInCOM: add GetSimpleComCallWrapper/GetSimpleComCallWrapperData; remove individual predicate APIs Mar 10, 2026
Copilot finished work on behalf of rcj1 March 10, 2026 05:41
…ative enum; consolidate all SCCW data into GetSimpleComCallWrapperData

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI changed the title cDAC BuiltInCOM: add GetSimpleComCallWrapper/GetSimpleComCallWrapperData; remove individual predicate APIs cDAC BuiltInCOM: Consolidate SCCW data into GetSimpleComCallWrapperData; remove redundant predicate APIs Mar 10, 2026
Copilot finished work on behalf of rcj1 March 10, 2026 07:01
@rcj1 rcj1 requested a review from Copilot March 11, 2026 00:17
Removed duplicate RCWCleanupInfo struct definition and related comments.
Copy link
Copy Markdown
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine but the PR description appears misleading, this PR is doing a lot more than just a contract API refactoring.

@rcj1 rcj1 changed the title cDAC BuiltInCOM: Consolidate SCCW data into GetSimpleComCallWrapperData; remove redundant predicate APIs Add cDAC API GetCCWData Mar 16, 2026
@rcj1 rcj1 marked this pull request as ready for review March 16, 2026 15:32
Copilot AI review requested due to automatic review settings March 16, 2026 15:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rcj1
Copy link
Copy Markdown
Contributor

rcj1 commented Mar 20, 2026

/ba-g OSX and android timing out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants