Skip to content

Revert "Disable iOS and tvOS jobs until infra issue is fixed"#125950

Merged
kotlarmilos merged 5 commits intomainfrom
revert-125771-disable-ios-tvos-jobs
Mar 27, 2026
Merged

Revert "Disable iOS and tvOS jobs until infra issue is fixed"#125950
kotlarmilos merged 5 commits intomainfrom
revert-125771-disable-ios-tvos-jobs

Conversation

@kotlarmilos
Copy link
Copy Markdown
Member

Reverts #125771

Copilot AI review requested due to automatic review settings March 23, 2026 09:02
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous pipeline change that disabled iOS and tvOS CI jobs, re-enabling those platforms in the runtime pipeline matrices.

Changes:

  • Re-enable ios_arm64 and tvos_arm64 in key eng/pipelines/runtime.yml platform matrices.
  • Re-enable ios_arm64 and tvos_arm64 across iOS-like “extra platforms” job matrices.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/pipelines/runtime.yml Restores iOS/tvOS platforms in multiple platform-matrix job definitions.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml Restores iOS/tvOS platforms across iOS-like extra-platform job matrices.

@kotlarmilos
Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@github-actions

This comment has been minimized.

Copilot AI review requested due to automatic review settings March 26, 2026 10:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copilot AI review requested due to automatic review settings March 27, 2026 09:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@github-actions
Copy link
Copy Markdown
Contributor

Note

This review was generated by GitHub Copilot.

🤖 Copilot Code Review — PR #125950

Holistic Assessment

Motivation: This PR re-enables iOS (ios_arm64) and tvOS (tvos_arm64) CI jobs that were temporarily disabled in PR #125771 due to an infrastructure issue tracked in #123796. The motivation is clear and well-justified — restoring CI coverage that was intentionally turned off as a temporary measure.

Approach: The change is a clean git revert of commit a65919da (PR #125771). It mechanically uncomments the platform entries across all 9 affected locations (6 in runtime-extra-platforms-ioslike.yml, 3 in runtime.yml) and removes the associated tracking issue comments. This is the correct approach for undoing a temporary disable.

Summary: ✅ LGTM. This is a straightforward revert that restores iOS and tvOS CI jobs to their previously working state. The YAML changes are syntactically correct, all 9 platform entries are consistently re-enabled, and no commented-out entries remain. No code, API, or behavioral changes are involved.


Detailed Findings

✅ Correctness — All platform entries consistently re-enabled

All 9 locations where ios_arm64 and tvos_arm64 were commented out have been correctly restored:

  • runtime-extra-platforms-ioslike.yml: 6 job definitions (Mono libraries, Mono runtime, NativeAOT libraries, NativeAOT runtime, CoreCLR R2R runtime, CoreCLR libraries)
  • runtime.yml: 3 job definitions (Mono smoke tests, CoreCLR smoke tests, NativeAOT smoke tests)

Each change is identical in structure — removing the # Tracking issue: comment and uncommenting both - ios_arm64 and - tvos_arm64. No entries were missed.

✅ YAML Syntax — Valid after changes

The indentation and list formatting are correct across all modified sections. The platforms: arrays properly contain the uncommented entries as list items.

✅ Scope — Minimal and focused

The PR contains only the revert changes with no unrelated modifications. The two files changed are exactly the same files modified by the original disable PR #125771.

Generated by Code Review for issue #125950 ·

@kotlarmilos
Copy link
Copy Markdown
Member Author

/ba-g non-mobile failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants