Merged
Conversation
kg
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @dotnet/jit-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a debug-build break in the WASM JIT lowering path by ensuring SetMultiplyUsed is called with the required debug-only “reason” argument in all debug configurations.
Changes:
- Update
Lowering::LowerIndexAddrto passDEBUGARG(...)reason strings toSetMultiplyUsedforArr()andIndex().
EgorBo
approved these changes
Mar 28, 2026
Member
Author
|
/ba-g Fixing build break on CI in debug-only, wasm-only code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streams got crossed with some merges so this made it through checks