JIT: Unify to instParamLookup and improve GVM test coverage#126947
Open
hez2010 wants to merge 27 commits into
Open
JIT: Unify to instParamLookup and improve GVM test coverage#126947hez2010 wants to merge 27 commits into
hez2010 wants to merge 27 commits into
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors CoreCLR devirtualization metadata to use a unified instParamLookup and expands JIT test coverage for generic virtual method (GVM) scenarios to support follow-on GVM devirtualization work.
Changes:
- Add a new GVM-focused runtime lookup/delegate test to broaden devirtualization coverage.
- Replace
CORINFO_DEVIRTUALIZATION_INFOad-hoc flags withinstParamLookup, and update JIT devirtualization logic to consume it. - Update SuperPMI and the managed JitInterface type definitions/serialization to match the new
CORINFO_DEVIRTUALIZATION_INFOshape (plus bump the JIT/EE versioning GUID).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs | Adds additional GVM/runtime-lookup-related test coverage. |
| src/coreclr/vm/jitinterface.cpp | Initializes/produces instParamLookup for devirtualization results (replacing older flags). |
| src/coreclr/jit/importercalls.cpp | Plumbs instParamLookup through devirtualization + guarded devirtualization candidate tracking and inserts instantiation args when required. |
| src/coreclr/jit/morph.cpp | Simplifies lookup-tree helpers to take CORINFO_LOOKUP directly. |
| src/coreclr/jit/compiler.h | Updates declarations for the new lookup-tree helper signatures and GDV candidate plumbing. |
| src/coreclr/inc/corinfo.h | Updates CORINFO_DEVIRTUALIZATION_INFO to carry instParamLookup instead of legacy flags; documents “no lookup needed” sentinel. |
| src/coreclr/inc/jiteeversionguid.h | Bumps the JIT/EE version GUID for the interface change. |
| src/coreclr/tools/Common/JitInterface/CorInfoTypes.cs | Mirrors the CORINFO_DEVIRTUALIZATION_INFO layout change in managed definitions. |
| src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs | Updates managed resolveVirtualMethod implementation to populate instParamLookup and method-context behavior. |
| src/coreclr/tools/superpmi/superpmi-shared/agnostic.h | Updates SuperPMI record structs to include instParamLookup. |
| src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp | Records/restores/dumps instParamLookup in SuperPMI method contexts. |
This was referenced Apr 15, 2026
Open
Contributor
Author
|
Test failure seems unrelated. |
Contributor
Author
|
Ping @jakobbotsch This is a refactor only change which is the prerequisites of the upcoming GVM devirt work, please take a look when you get some time. |
Contributor
jakobbotsch
reviewed
Apr 24, 2026
hez2010
force-pushed
the
shared-gvm-devirt/1-tests-instparamlookup
branch
from
75dec5b to
4da609f
Compare
hez2010
force-pushed
the
shared-gvm-devirt/1-tests-instparamlookup
branch
from
4da609f to
42d5011
Compare
jakobbotsch
reviewed
Apr 25, 2026
Member
|
/azp run runtime-coreclr pgo, runtime-coreclr libraries-pgo, runtime-coreclr pgostress |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jakobbotsch
reviewed
May 11, 2026
jakobbotsch
reviewed
May 11, 2026
jakobbotsch
reviewed
May 11, 2026
jakobbotsch
reviewed
May 11, 2026
Contributor
Author
|
Resolved in 173e637. PTAL |
hez2010
force-pushed
the
shared-gvm-devirt/1-tests-instparamlookup
branch
from
42b1c02 to
fd5bafb
Compare
…ests-instparamlookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #123323. This PR is the first step in splitting the shared GVM devirtualization work.
It does two things:
CORINFO_DEVIRTUALIZATION_INFOwith a singleinstParamLookupContributes to #112596
/cc: @jakobbotsch