Remove the concept of primitive value types and follow up cleanup by Copilot · Pull Request #127894 · dotnet/runtime

Copilot · 2026-05-07T00:33:27Z

Primitive value types were vestiges of very old x86 calling convention handling that became unnecessary many years ago.

This change deletes the concept of primitive value types. We only have primitives (Int32, etc. including enums) and true primitives (Int32, etc. without enums) now. Deleting this concept enabled follow up cleanup:

Delete GetVerifierCorElementType and replaces all call sites with GetInternalCorElementType
Remove special-casing of runtime handle structs (RuntimeArgumentHandle, RuntimeMethodHandleInternal, RuntimeFieldHandleInternal) in the type loader
Stop treating TypedReference as primitive some of the time. TypedReference is a regular byref-like value type now.

…gory to enum Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas

@copilot

dotnet-policy-service · 2026-05-07T00:57:42Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas

@copilot

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/4ef6b0df-8fc1-41d6-afe1-1119ff0f3c32 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-10T00:28:30Z

They don't have valid EEClass pointers (causing GetClass() to fail)

This is invalid conclusion. These types do have a valid EEClass pointer. The failing GetClass() call was a second order effect....

Fixed in 8cd4494. The solution identifies RuntimeArgumentHandle, RuntimeMethodHandleInternal, and RuntimeFieldHandleInternal by name in lvaInitVarDsc and treats them as TYP_I_IMPL instead of TYP_STRUCT. This avoids calling GetClass() or other struct-specific operations on these types. CoreCLR builds successfully.

…InitVarDsc" This reverts commit 8cd4494.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/2acd0c3a-e4f9-4316-bc72-a1462ef61397 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b25dfaef-9df2-4161-8c86-129dd0b25ea8 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/43600cbc-8cd7-4f70-aa1d-a272a469e4ad Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/23221766-5057-454a-b53d-f8904a0ae9eb Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

jkotas · 2026-05-18T22:39:26Z

@copilot Merge from main and resolve conflicts

Copilot · 2026-05-18T22:43:48Z

@copilot Merge from main and resolve conflicts

Merged main and resolved conflicts in commit 361b54f.

jkotas · 2026-05-18T23:33:00Z

@copilot Do that again and don't forget to push the merge commit into the PR

…delete-primitive-value-types # Conflicts: # src/coreclr/vm/jitinterface.cpp Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-18T23:40:49Z

@copilot Do that again and don't forget to push the merge commit into the PR

Done in 90c7b6f: merged latest main, resolved the src/coreclr/vm/jitinterface.cpp conflict, and pushed the merge commit to this PR branch.

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0b309854-d541-4fd7-9c78-ad6d8929f887 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas · 2026-05-19T01:33:50Z

@rcj1 PTLA. Cleanup discussed in #127877 (comment)

Copilot AI and others added 2 commits May 7, 2026 00:21

Remove verifier element type API and rename primitive-value-type cate…

7d196a3

…gory to enum Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Rename enum category in cDAC contracts/docs and clean related comments

0af6cad

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI assigned Copilot and jkotas May 7, 2026

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:33

Copilot created this pull request from a session on behalf of jkotas May 7, 2026 00:34 View session

Copilot finished work on behalf of jkotas May 7, 2026 00:34

Copilot AI requested a review from jkotas May 7, 2026 00:34

jkotas reviewed May 7, 2026

View reviewed changes

Copilot started work on behalf of jkotas May 7, 2026 00:56 View session

github-actions Bot added the area-VM-coreclr label May 7, 2026

jkotas mentioned this pull request May 7, 2026

[cDAC] implement DacDbi GetTypeLayout/GetArrayLayout #127877

Merged

Address review feedback on enum/primitive category values and comments

fbca1de

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:35

Refine RuntimeHelpers primitive checks after review tool feedback

2bdd2da

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:43

Clarify primitive/enum mask behavior comment in MethodTable

4a179b3

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:46

Copilot AI changed the title ~~Delete primitive value type category concept from runtime~~ Remove primitive value type concept and normalize enum/primitive category flags May 7, 2026

Copilot finished work on behalf of jkotas May 7, 2026 01:47

Copilot AI requested a review from jkotas May 7, 2026 01:47

jkotas reviewed May 7, 2026

View reviewed changes

Copilot started work on behalf of jkotas May 7, 2026 02:20 View session

Apply latest enum/primitive review suggestions across runtime and cDAC

53d2152

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/4ef6b0df-8fc1-41d6-afe1-1119ff0f3c32 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 7, 2026 02:55

Revert "Handle runtime handle internal types as TYP_I_IMPL in JIT lva…

09d4978

…InitVarDsc" This reverts commit 8cd4494.

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp

build-analysis Bot mentioned this pull request May 11, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

jkotas added 2 commits May 14, 2026 19:39

Merge branch 'main' into copilot/delete-primitive-value-types

a6e2dbe

More

a5c7ff8

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread docs/design/datacontracts/RuntimeTypeSystem.md Outdated

jkotas and others added 3 commits May 14, 2026 21:15

More

ffdefa1

More

2cd4088

Update RuntimeTypeSystem docs to use Category_Enum naming

29930e8

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/2acd0c3a-e4f9-4316-bc72-a1462ef61397 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread docs/design/datacontracts/RuntimeTypeSystem.md Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread ...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

Rename RuntimeTypeSystem doc flag to Category_Primitive

18c574c

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b25dfaef-9df2-4161-8c86-129dd0b25ea8 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread ...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

Copilot AI and others added 3 commits May 15, 2026 05:25

Rename IsPrimitiveMask constant to ElementTypeMask in RuntimeHelpers

4cc66e2

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/43600cbc-8cd7-4f70-aa1d-a272a469e4ad Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Rename Category_Enum to Category_Primitive across runtime flags

2491a23

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/23221766-5057-454a-b53d-f8904a0ae9eb Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Merge branch 'main' into copilot/delete-primitive-value-types

361b54f

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp Outdated

This was referenced May 16, 2026

browser-wasm linux Release LibraryTests queues timing out #117974

Open

ExceptionHandlingExpressions.ExpressionsUnwrapeExternallyThrownRuntimeWrappedException failure #128164

Open

Merge remote-tracking branch 'refs/remotes/origin/main' into copilot/…

90c7b6f

…delete-primitive-value-types # Conflicts: # src/coreclr/vm/jitinterface.cpp Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI reviewed May 19, 2026

View reviewed changes

Comment thread src/coreclr/vm/methodtablebuilder.cpp

Handle TypedReference explicitly in ZapSig type comparison

2f33264

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/0b309854-d541-4fd7-9c78-ad6d8929f887 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

This was referenced May 19, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

[wasm] Tests failing with DirectoryNotFoundException trying to load test data #128293

Open

Conversation

Copilot AI commented May 7, 2026 • edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 7, 2026

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jkotas commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026

Uh oh!

jkotas commented May 18, 2026

Uh oh!

Copilot AI commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jkotas commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 7, 2026 •

edited by jkotas

Loading