JIT: Enable fgOptimizeRelationalComparisonWithCasts for EQ/NE

[BoyBaykiller]

We were previously only calling that for GT_LT, GT_LE, GT_GE, GT_GT.
Example:

bool Test(uint a)
{
    return (ulong)(a) == uint.MaxValue;
}

;; ------ BASE
G_M000_IG02:
       mov      eax, edx
       mov      ecx, 0xFFFFFFFF
       cmp      rax, rcx
       sete     al
       movzx    rax, al

;; ------ DIFF
G_M60965_IG02:
       cmp      edx, -1
       sete     al
       movzx    rax, al

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[BoyBaykiller]

Reason I moved this down:

When calling this function for EQ/NE this assert fired in some coreclr_tests. And moving it after the supportedOp check fixes it. This is the tree it failed on:

[000030] --CXG------                         *  EQ        int   
[000013] --CXG+-----                         +--*  CALL help ref    CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE_MAYBENULL
[000469] n---G+----- arg0 rcx                |  \--*  IND       byref 
[000468] -----+-----                         |     \--*  ADD       byref 
[000011] -----+-----                         |        +--*  LCL_VAR   byref  V01 arg1         
[000467] -----+-----                         |        \--*  CNS_INT   long   8
[000029] ----G+---U-                         \--*  CAST      long <- uint
[000470] ----G+-----                            \--*  EQ        int   
[000473] n---G+-----                               +--*  IND       byref 
[000472] -----+-----                               |  \--*  ADD       byref 
[000018] -----+-----                               |     +--*  LCL_VAR   byref  V02 arg2         
[000471] -----+-----                               |     \--*  CNS_INT   long   8
[000476] n---G+-----                               \--*  IND       byref 
[000475] -----+-----                                  \--*  ADD       byref 
[000025] -----+-----                                     +--*  LCL_VAR   byref  V03 arg3         
[000474] -----+-----                                     \--*  CNS_INT   long   8

[BoyBaykiller]

This is the (only) meaningful change.

[BoyBaykiller]

@EgorBo PTAL. Simple change

[EgorBo]

why? if you think this assert is incorrect you should fix it, not move it to somewhere to silence it

[BoyBaykiller]

Hm, doesn't it make sense to move it after the supportedOp check