Skip to content

Turn CRLF -> LF in CorInfoImpl.ReadyToRun.cs and fix a build break#128099

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-eols
May 12, 2026
Merged

Turn CRLF -> LF in CorInfoImpl.ReadyToRun.cs and fix a build break#128099
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-eols

Conversation

@jakobbotsch
Copy link
Copy Markdown
Member

#126904 committed these line with CRLFs instead of LFs, causing them to be reported as always changing when the repo is checked out on Windows and making it impossible to discard the changes.

Copilot AI review requested due to automatic review settings May 12, 2026 20:51
@github-actions github-actions Bot added the area-crossgen2-coreclr only use for closed issues label May 12, 2026
@jakobbotsch jakobbotsch requested a review from jtschuster May 12, 2026 20:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copy link
Copy Markdown
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jakobbotsch
Copy link
Copy Markdown
Member Author

It seems there is a build break too, probably a conflict with some other recent change. I pushed a fix for it here too.

@jakobbotsch jakobbotsch changed the title Turn CRLF -> LF in CorInfoImpl.ReadyToRun.cs Turn CRLF -> LF in CorInfoImpl.ReadyToRun.cs and fix a build break May 12, 2026
@jtschuster
Copy link
Copy Markdown
Member

Ah, yeah, I didn't rebase after 3caa97a was merged before merging my PR.

@jtschuster
Copy link
Copy Markdown
Member

Sounds like the build break is failing all PRs, should we yolo merge? Not sure who has access for that, though

@jakobbotsch
Copy link
Copy Markdown
Member Author

Sounds like the build break is failing all PRs, should we yolo merge? Not sure who has access for that, though

Yeah, I just want to validate some pipeline here passes build. I can merge it with /ba-g

@jakobbotsch
Copy link
Copy Markdown
Member Author

/ba-g Builds are passing, merging to unblock CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-crossgen2-coreclr only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants