Turn CRLF -> LF in CorInfoImpl.ReadyToRun.cs and fix a build break#128099
Merged
Conversation
Member
Author
|
It seems there is a build break too, probably a conflict with some other recent change. I pushed a fix for it here too. |
Member
|
Ah, yeah, I didn't rebase after 3caa97a was merged before merging my PR. |
Member
|
Sounds like the build break is failing all PRs, should we yolo merge? Not sure who has access for that, though |
Member
Author
Yeah, I just want to validate some pipeline here passes build. I can merge it with /ba-g |
Member
Author
|
/ba-g Builds are passing, merging to unblock CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#126904 committed these line with CRLFs instead of LFs, causing them to be reported as always changing when the repo is checked out on Windows and making it impossible to discard the changes.