ILTrim: make custom-attribute type-name rewrite best-effort#128122
Closed
Copilot wants to merge 1 commit into
Closed
ILTrim: make custom-attribute type-name rewrite best-effort#128122Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Copilot
AI
changed the title
[WIP] [WIP] Rework PR description to address feedback on custom attribute value parsing PR
ILTrim: make custom-attribute type-name rewrite best-effort
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacked PR updates the custom-attribute value rewrite path in ILTrim to avoid failing on unresolved serialized type names. Rewriting now happens only when type-name resolution succeeds, preserving original payload data otherwise.