[Wasm] Instantiate error detection - #128167
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves diagnostics in the WASM corerun host when loading Webcil/R2R modules fails because __stack_pointer is unavailable.
Changes:
- Adds an explicit
__stack_pointeravailability check before WebAssembly instantiation. - Logs instantiation failures with the wasm path and error message.
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
Author
davidwrighton
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better failure mode when trying to load an R2R module using a release build of corerun.js.