Update EmsdkPackageVersion to use version from dependency flow

[akoeplinger]

It got hardcoded a while ago to workaround a build problem.

[Copilot]

Pull request overview

This PR updates the build’s Emscripten SDK provisioning versioning so it no longer relies on a hardcoded EmsdkPackageVersion value in eng/Versions.props, instead sourcing it from a dependency-flow-updated property.

Changes:

• Replace the hardcoded EmsdkPackageVersion (10.0.0) with $(MicrosoftDotNetApiCompatTaskPackageVersion).
• Add an explanatory comment about why a stable, dependency-flow-backed version property is used.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[github-actions]

Caution

Security scanning requires review for Code Review

Details

The threat detection results could not be parsed. The workflow output should be reviewed before merging.

Review the workflow run logs for details.

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #128261

Holistic Assessment

Motivation: Justified — removing a hardcoded version (10.0.0) that was a workaround and replacing it with the dependency-flowed version eliminates manual bump maintenance.

Approach: Correct — uses $(MicrosoftNETCoreAppRefPackageVersion) (currently 11.0.0-preview.5.26257.113) which provides runtime version numbers matching the emsdk package ID pattern. This mirrors how MicrosoftNETRuntimeEmscriptenVersion already uses a flowed version on the adjacent line.

Summary: ✅ LGTM. Single-property change in eng/Versions.props, aligning EmsdkPackageVersion with dependency flow. The consumers in eng/AcquireEmscriptenSdk.targets and src/mono/mono.proj will now automatically get the correct version without manual updates.

---

Detailed Findings

✅ Correctness — Version source is appropriate

MicrosoftNETCoreAppRefPackageVersion (defined in eng/Version.Details.props) provides runtime-style version numbers (e.g., 11.0.0-preview.5.26257.113), which matches the versioning scheme used by the emsdk NuGet packages (Microsoft.NET.Runtime.Emscripten.{EmsdkVersion}.{component}). The comment added in the PR correctly explains the rationale.

✅ Consistency — Follows established pattern

The adjacent MicrosoftNETRuntimeEmscriptenVersion already uses a flowed version ($(MicrosoftDotNetApiCompatTaskPackageVersion)) for the same reason. This PR makes EmsdkPackageVersion consistent with that approach.

✅ Scope — Minimal and focused

Only one property value changed, with appropriate explanatory comments added. No risk of unintended side effects.

Generated by Code Review for issue #128261 · ● 1.7M · ◷