Reduce parallelism for composite crossgen2 for jit64_3 test#128269
Draft
Copilot wants to merge 11 commits into
Draft
Reduce parallelism for composite crossgen2 for jit64_3 test#128269Copilot wants to merge 11 commits into
Copilot wants to merge 11 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9738ecd5-72f4-4da1-a593-022aeffb7149 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9738ecd5-72f4-4da1-a593-022aeffb7149 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9738ecd5-72f4-4da1-a593-022aeffb7149 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/9738ecd5-72f4-4da1-a593-022aeffb7149 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/13b5c474-2ae7-4114-aca8-6aa65b6dddc0 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jtschuster
May 15, 2026 21:56
View session
Member
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jtschuster
reviewed
May 15, 2026
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e6627b08-90e0-4233-aa39-2bc9f018a772 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e6627b08-90e0-4233-aa39-2bc9f018a772 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/05b5e509-39b1-4a44-91f0-c12b5e81d58c Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Open
3 tasks
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/adc88170-a41d-41de-b36b-68e1ff6af919 Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Add a composite-only Crossgen2 extra arguments property and use it to lower jit64_3 composite compilation parallelism to avoid concurrent native JIT allocation spikes from huge methods. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jtschuster
changed the title
Member
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new MSBuild hook for tests to supply extra CrossGen2 arguments only when running in composite mode, and uses it in jit64_3 to reduce CrossGen2 parallelism (presumably to mitigate memory pressure from very large JIT methods during composite compilation).
Changes:
- Add
CompositeCrossGen2TestExtraArgumentsas a new test-project property and plumb it into the generated CrossGen2 scripts (bash + batch) in composite mode. - Set
jit64_3to pass--parallelism:2via the new composite-only property.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/jit64/jit64_3.csproj | Adds composite-only CrossGen2 extra args to throttle CrossGen2 parallelism for this test group. |
| src/tests/Common/CLRTest.CrossGen.targets | Documents and appends a new composite-only CrossGen2 argument property in generated scripts. |
3 tasks
jtschuster
reviewed
May 18, 2026
Member
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -1,4 +1,9 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <!-- Huge methods need large native JIT allocations, so limit concurrent Crossgen2 compilations. --> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jit64_3split files./build.sh clr+libs -lc release -rc checkedjit64_3_huge.csprojneeds to remain split outjit64_3.csprojto include allopt/**/*.??projexceptopt/cse/Huge*.??projjit64_3.csprojandjit64_3_huge.csprojin checked composite CrossGen2 mode