Remove -Wno-unused-function -Wno-tautological-compare -Wno-unused-value for clrjit projects by EgorBo · Pull Request #128271 · dotnet/runtime

EgorBo · 2026-05-15T22:54:11Z

We currently define the followings for the entire native code:

add_compile_options(-Wno-unused-variable)
add_compile_options(-Wno-unused-value)
add_compile_options(-Wno-unused-function)
add_compile_options(-Wno-tautological-compare)
add_compile_options(-Wno-unknown-pragmas)

my initial attempt to remove them all led to a very big diff so I decided to focus on JIT first.

dotnet-policy-service · 2026-05-15T22:55:32Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Re-enables -Wunused-function for the JIT (by removing the repo-wide -Wno-unused-function for this directory on Unix/WASI) and fixes the warnings that surfaced. This includes guarding several helpers with the same #ifdef conditions as their callers, deleting a truly unused overload, and incidentally repairing two bugs (a missing assignment and a discarded expression) that the warning exposed.

Changes:

Enable -Wunused-function for clrjit targets via a new block in src/coreclr/jit/CMakeLists.txt.
Guard target/DEBUG-only helpers (RelopEvaluationResultString, TryGetStoreCoalescingConstantBits, MatchIntConstSelectValues/IntConstSelectOper, isLowSimdReg) with matching #ifdefs, and delete the unused CorInfoType-taking isSupportedBaseType overload.
Fix two latent bugs uncovered by the warning: a missing id = assignment in GetHWIntrinsicIdForCmpOp (GT_GT/isScalar/xarch path) and discarded impPopStack().val expressions in impIntrinsic.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/jit/CMakeLists.txt	Strip `-Wno-unused-function` from the JIT directory's compile options on Unix/WASI.
src/coreclr/jit/scev.cpp	Wrap debug-only `RelopEvaluationResultString` in `#ifdef DEBUG`.
src/coreclr/jit/lower.cpp	Guard `TryGetStoreCoalescingConstantBits` for `TARGET_XARCH`/`TARGET_ARM64`.
src/coreclr/jit/ifconversion.cpp	Guard `IntConstSelectOper`/`MatchIntConstSelectValues` for `TARGET_RISCV64`.
src/coreclr/jit/emitxarch.cpp	Wrap debug-only `isLowSimdReg` in `#ifdef DEBUG`.
src/coreclr/jit/hwintrinsic.cpp	Remove unused `CorInfoType`-overload of `isSupportedBaseType`; remaining `var_types` overload is the one used at all call sites.
src/coreclr/jit/gentree.cpp	Fix missing `id =` assignment in scalar GT_GT case in `GetHWIntrinsicIdForCmpOp`.
src/coreclr/jit/importercalls.cpp	Replace `impPopStack().val;` no-op statements with `impPopStack();`.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

EgorBo · 2026-05-16T00:28:47Z

PTAL @dotnet/jit-contrib minor cleanup, I'll do the clean up for unused vars separately as it emits too many changes (and probably will not remove that flag for variables)

No diffs

EgorBo · 2026-05-16T00:29:16Z

            else if (isScalar)
            {
-                reverseCond ? NI_X86Base_CompareScalarNotLessThanOrEqual : NI_X86Base_CompareScalarGreaterThan;
+                id = reverseCond ? NI_X86Base_CompareScalarNotLessThanOrEqual : NI_X86Base_CompareScalarGreaterThan;


apparently, this was a bug

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

EgorBo · 2026-05-18T11:16:51Z


            regNumber baseReg = id->idReg2();
-            if (baseReg != REG_SP || baseReg != REG_FP)
+            if ((baseReg != REG_SP) && (baseReg != REG_FP))


this was a bug too (previous code was "always true") but given it just for insLatency (PerfScore) computation - it's not a big deal

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

The Attributes.BoxedValues test now passes after dotnet#127596 added custom attribute blob parsing and rewriting, but the entry was not removed from ILTrimExpectedFailures.txt. CLR_Tools_Tests fails with: Test 'Attributes.BoxedValues' is in the expected failures list but now passes. Remove it from ILTrimExpectedFailures.txt. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

EgorBo · 2026-05-18T18:41:40Z

ping @dotnet/jit-contrib simple clean up, no diffs

the idea is to enforce some warnings to prevent bugs like the one I fixed

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

EgorBo and others added 2 commits May 16, 2026 00:15

fix bug

76f47b2

unused

834dd45

Copilot AI review requested due to automatic review settings May 15, 2026 22:54

Copilot started reviewing on behalf of EgorBo May 15, 2026 22:54 View session

github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 15, 2026

dotnet-policy-service Bot assigned EgorBo May 15, 2026

Update importercalls.cpp

e1a44ae

Copilot AI reviewed May 15, 2026

View reviewed changes

EgorBo added 3 commits May 16, 2026 00:58

tautological-compare

3366f08

Merge branch 'fix-warn' of github.com:EgorBo/runtime-1 into fix-warn

07d6571

more

8ed0e6d

Copilot AI review requested due to automatic review settings May 15, 2026 23:08

Copilot started reviewing on behalf of EgorBo May 15, 2026 23:08 View session

EgorBo changed the title ~~Remove -Wno-unused-function for clrjit projects~~ Remove -Wno-unused-function -Wno-tautological-compare -Wno-unused-value for clrjit projects May 15, 2026

Copilot AI reviewed May 15, 2026

View reviewed changes

EgorBo requested a review from a team May 16, 2026 00:28

EgorBo commented May 16, 2026

View reviewed changes

This was referenced May 16, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Unable to pull image from mcr.microsoft.com #117164

Open

Fix JIT warnings-as-errors

0a8ec94

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This was referenced May 16, 2026

Android WebSocket failure #121518

Open

[wasm] Tests failing with DirectoryNotFoundException trying to load test data #128293

Open

fix risc-v

a8fa9fc

Copilot AI review requested due to automatic review settings May 18, 2026 11:15

Merge branch 'main' of https://github.com/dotnet/runtime into fix-warn

6d992ae

EgorBo commented May 18, 2026

View reviewed changes

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread src/coreclr/jit/CMakeLists.txt Outdated

Comment thread src/coreclr/jit/emitxarch.cpp

Comment thread src/coreclr/jit/lower.cpp

Copilot started reviewing on behalf of EgorBo May 18, 2026 11:26 View session

Potential fix for pull request finding

25f79c2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 18, 2026 11:27

Copilot started reviewing on behalf of EgorBo May 18, 2026 11:27 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Update ILTrimExpectedFailures.txt

ea84cf8

Copilot AI review requested due to automatic review settings May 18, 2026 19:54

Copilot started reviewing on behalf of EgorBo May 18, 2026 19:54 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread src/coreclr/tools/ILTrim.Tests/ILTrimExpectedFailures.txt Outdated

build-analysis Bot mentioned this pull request May 18, 2026

ExceptionHandlingExpressions.ExpressionsUnwrapeExternallyThrownRuntimeWrappedException failure #128164

Open

EgorBo added 2 commits May 19, 2026 17:16

Merge branch 'main' into fix-warn

0af20bf

Update ILTrimExpectedFailures.txt

fd303ba

Copilot AI review requested due to automatic review settings May 19, 2026 15:17

Copilot started reviewing on behalf of EgorBo May 19, 2026 15:17 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

This was referenced May 19, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

Conversation

EgorBo commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

EgorBo commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EgorBo May 16, 2026

Choose a reason for hiding this comment

Uh oh!

EgorBo May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

EgorBo commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EgorBo commented May 15, 2026 •

edited

Loading

EgorBo commented May 16, 2026 •

edited

Loading

EgorBo commented May 18, 2026 •

edited

Loading