Skip to content

Extend async override virtual call coverage #128313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+61 −0
Open

Extend async override virtual call coverage #128313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ca741
Add async override virtual await coverage
Copilot May 18, 2026
f1ceef1
Simplify, this doesn't involve shared generics anyway
MichalStrehovsky May 21, 2026
9f303d4
Update override.cs
MichalStrehovsky May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions src/tests/async/override/override.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ public virtual async Task<int> M1()
await Task.Yield();
return 1;
}

public virtual async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return default(T);
}
Comment thread
MichalStrehovsky marked this conversation as resolved.
Comment thread
MichalStrehovsky marked this conversation as resolved.
}

class Derived1 : Base
Expand All @@ -25,6 +31,12 @@ public override async Task<int> M1()
await Task.Yield();
return 2;
}

public override async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return first;
}
}

class Derived2 : Derived1
Expand All @@ -34,6 +46,12 @@ public override async Task<int> M1()
await Task.Yield();
return 3;
}

public override async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return second;
}
}


Expand All @@ -45,6 +63,12 @@ public virtual async Task<int> M1()
await Task.Yield();
return 11;
}

public virtual async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return default(T);
}
}

class Derived11 : Base1
Expand All @@ -54,6 +78,12 @@ public override async Task<int> M1()
await Task.Yield();
return 12;
}

public override async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return first;
}
}

class Derived12 : Derived11
Expand All @@ -64,30 +94,61 @@ public override async Task<int> M1()
await Task.Yield();
return 13;
}

public override async Task<T> M2<T>(T first, T second)
{
await Task.Yield();
return second;
}
}

[MethodImpl(MethodImplOptions.NoInlining)]
static async Task<int> AwaitBaseM1(Base b) => await b.M1();

[MethodImpl(MethodImplOptions.NoInlining)]
static async Task<int> AwaitBaseM1(Base1 b) => await b.M1();

[MethodImpl(MethodImplOptions.NoInlining)]
static async Task<T> AwaitBaseM2<T>(Base b, T first, T second) => await b.M2(first, second);

[MethodImpl(MethodImplOptions.NoInlining)]
static async Task<T> AwaitBaseM2<T>(Base1 b, T first, T second) => await b.M2(first, second);

[Fact]
public static void TestEntryPoint()
{
Base b = new Derived1();
Assert.Equal(2, b.M1().Result);
Assert.Equal(2, AwaitBaseM1(b).Result);
Assert.Equal(2, b.M2(2, 3).Result);
Assert.Equal(2, AwaitBaseM2(b, 2, 3).Result);

Comment thread
MichalStrehovsky marked this conversation as resolved.
b = new Derived2();
Assert.Equal(3, b.M1().Result);
Assert.Equal(3, AwaitBaseM1(b).Result);
Assert.Equal(3, b.M2(2, 3).Result);
Assert.Equal(3, AwaitBaseM2(b, 2, 3).Result);

Derived1 d = new Derived2();
Assert.Equal(3, d.M1().Result);
Assert.Equal(3, d.M2(2, 3).Result);


Base1 b1 = new Derived11();
Assert.Equal(12, b1.M1().Result);
Assert.Equal(12, AwaitBaseM1(b1).Result);
Assert.Equal(12, b1.M2(12, 13).Result);
Assert.Equal(12, AwaitBaseM2(b1, 12, 13).Result);

b1 = new Derived12();
Assert.Equal(13, b1.M1().Result);
Assert.Equal(13, AwaitBaseM1(b1).Result);
Assert.Equal(13, b1.M2(12, 13).Result);
Assert.Equal(13, AwaitBaseM2(b1, 12, 13).Result);

Derived11 d1 = new Derived12();
Assert.Equal(13, d1.M1().Result);
Assert.Equal(13, d1.M2(12, 13).Result);

}
}
Loading