Remove stale test analyzer suppressions#128315
Merged
MichalStrehovsky merged 2 commits intoMay 18, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes stale EnableTrimAnalyzer/EnableAotAnalyzer suppressions in test project files that were originally added as workarounds for #126862. With analyzer improvements and Arcade fixes, the suppressions are no longer needed.
Changes:
- Removes
EnableAotAnalyzer=falseand/orEnableTrimAnalyzer=falsesuppressions from ~23 test.csprojfiles. - Removes the corresponding
<!-- https://github.com/dotnet/runtime/issues/126862 -->comment where both suppressions were dropped; comments are retained where one suppression still remains.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/Microsoft.Extensions.Logging/tests/Common/Microsoft.Extensions.Logging.Tests.csproj | Drop stale AOT analyzer suppression. |
| src/libraries/Microsoft.Win32.SystemEvents/tests/Microsoft.Win32.SystemEvents.Tests.csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.DirectoryServices.AccountManagement/tests/...Tests.csproj | Drop stale trim analyzer suppression. |
| src/libraries/System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.IO.MemoryMappedFiles/tests/...Tests.csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/...csproj | Drop stale AOT analyzer suppression (trim suppression kept). |
| src/libraries/System.Net.Http/tests/FunctionalTests/...csproj | Drop stale AOT analyzer suppression (trim suppression kept). |
| src/libraries/System.Net.Http/tests/UnitTests/...csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Net.Mail/tests/Functional/...csproj | Drop stale trim analyzer suppression (AOT suppression kept). |
| src/libraries/System.Net.NameResolution/tests/FunctionalTests/...csproj | Drop stale trim analyzer suppression. |
| src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/...csproj | Drop both trim and AOT suppressions. |
| src/libraries/System.Net.Ping/tests/FunctionalTests/...csproj | Drop stale trim analyzer suppression. |
| src/libraries/System.Net.Primitives/tests/FunctionalTests/...csproj | Drop both trim and AOT suppressions. |
| src/libraries/System.Net.Security/tests/FunctionalTests/...csproj | Drop stale trim analyzer suppression (AOT suppression kept). |
| src/libraries/System.Net.Security/tests/UnitTests/...csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Net.Sockets/tests/FunctionalTests/...csproj | Drop both trim and AOT suppressions. |
| src/libraries/System.Private.Xml.Linq/tests/misc/...csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Runtime/tests/System.Globalization.Tests/Invariant/Invariant.Tests.csproj | Drop stale trim analyzer suppression. |
| src/libraries/System.Security.AccessControl/tests/...csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Security.Cryptography.Cng/tests/...csproj | Drop stale AOT analyzer suppression (trim suppression kept). |
| src/libraries/System.Security.Cryptography.Cose/tests/...csproj | Drop stale AOT analyzer suppression. |
| src/libraries/System.Security.Cryptography.Csp/tests/...csproj | Drop stale AOT analyzer suppression (trim suppression kept). |
| src/libraries/System.Threading/tests/System.Threading.Tests.csproj | Drop stale AOT analyzer suppression. |
This was referenced May 18, 2026
Open
This was referenced May 18, 2026
Member
Author
|
/ba-g helix workitem crash in interpreter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are no longer needed thanks to extra analysis and Arcade fixes.
Cc @dotnet/illink