Enable trim and AOT analyzers for selected library tests by Copilot · Pull Request #128355 · dotnet/runtime

Copilot · 2026-05-19T03:06:42Z

Description

Several library test projects suppressed trim/AOT analyzer warnings by disabling the analyzers at the project level. This change enables the analyzers and replaces broad suppressions with targeted fixes or narrow warning pragmas at known test-only reflection and dynamic-code sites.

Removed the dotnet/runtime#126862 analyzer-disable blocks from the listed test projects.
Replaced avoidable warnings with analyzer-friendly code, such as DiagnosticMethodInfo, Enum.GetValues<TEnum>(), and LINQ-based collection conversion.
Updated System.Threading.RateLimiting.Tests to reference the source project with SkipUseReferenceAssembly="true" and avoid local reflection suppressions.
Added narrow #pragma warning disable/restore scopes only for remaining emitted IL warnings that require reflection, dynamic code, or unsupported trim/AOT analysis patterns.
Added explanatory context to the remaining System.IO.Packaging dynamic-code suppression.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5977beb1-58f4-4a75-9a1c-02ff1bb17294 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

dotnet-policy-service · 2026-05-19T03:32:24Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky

@copilot

MichalStrehovsky · 2026-05-19T03:12:08Z

            foreach (var stackFrame in new StackTrace(1).GetFrames().Take(2))
            {
+#pragma warning disable IL2026
                if (SkippedTests.Contains(stackFrame.GetMethod().Name))


Replace stackFrame.GetMethod().Name with DiagnosticMethodInfo.Create(stackFrame).Name and remove the pragma warning suppression.

Addressed in 768bc81 by switching to DiagnosticMethodInfo.Create(stackFrame)?.Name and removing the pragma.

MichalStrehovsky · 2026-05-19T03:15:41Z

            using var zipArchive = new ZipArchive(ms, ZipArchiveMode.Read);
            string[] archiveNames = partPieceLists.Split(',');

+#pragma warning disable IL3050


Suggested change

#pragma warning disable IL3050

#pragma warning disable IL3050 // s_ZipPackagePartPieceType is a reference type, this is safe to suppress

Addressed in 737b3d6 by adding the explanatory comment to the IL3050 suppression.

MichalStrehovsky · 2026-05-19T03:26:35Z

            var syncSendAdapterType = Type.GetType("System.Net.SyncReadWriteAdapter, System.Net.Mail");

            // Send the message.
+#pragma warning disable IL3050


This should not be triggering a warning. It probably triggers a warning because this test is compiled against a reference assembly that doesn't have the non-public SendAsync method. Is it possible to remove this suppression and instead fix the project to reference the src\libraries\System.Net.Mail\src\System.Net.Mail.csproj project? You might need to set SkipUseReferenceAssembly="true"

I tested referencing the source project with SkipUseReferenceAssembly, but it did not remove the MakeGenericMethod IL3050 warning and introduced unrelated LoggingTest trim warnings, so I left this targeted suppression unchanged.

MichalStrehovsky · 2026-05-19T03:29:36Z

        {
            var tls13cs = new HashSet<TlsCipherSuite>(GetTls13CipherSuites());
+#pragma warning disable IL3050
            foreach (TlsCipherSuite cs in typeof(TlsCipherSuite).GetEnumValues())


Suggested change

foreach (TlsCipherSuite cs in typeof(TlsCipherSuite).GetEnumValues())

foreach (TlsCipherSuite cs in Enum.GetValues<TlsCipherSuite>())

And remove the suppression.

Addressed in 737b3d6 by using Enum.GetValues<TlsCipherSuite>() and removing the suppression.

MichalStrehovsky · 2026-05-19T03:39:22Z

            Assert.Equal(bypassLocal, p.BypassProxyOnLocal);
            Assert.Equal(bypassedAddresses, p.BypassList);
+#pragma warning disable IL3050
            Assert.Equal(bypassedAddresses, (string[])p.BypassArrayList.ToArray(typeof(string)));


Suggested change

Assert.Equal(bypassedAddresses, (string[])p.BypassArrayList.ToArray(typeof(string)));

Assert.Equal(bypassedAddresses, p.BypassArrayList.Cast<string>().ToArray());

Then remove the suppression, add using System.Linq. Do the same change for the below lines too.

Addressed in 737b3d6 by switching the BypassArrayList assertions to Cast<string>().ToArray() and removing the suppressions.

MichalStrehovsky · 2026-05-19T03:48:00Z

            if (string.Empty.Length > 0)
                limiterType = limiterTypeDef;

+#pragma warning disable IL2075


This warning is probably also because we're compiling the test against the reference assembly that doesn't have the DefaultPartitionedRateLimiter. See if we can compile against the source project.

Addressed in 737b3d6 by referencing the source project with SkipUseReferenceAssembly="true" and making the helper use the source-visible constructed type without local pragmas.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5a0b0c7b-d13e-4936-8392-ff08d859bc72 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot AI and others added 2 commits May 19, 2026 02:37

Enable trim and AOT analyzers in listed tests

4038d80

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5977beb1-58f4-4a75-9a1c-02ff1bb17294 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Suppress trim and AOT analyzer warnings in tests

0150f13

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5977beb1-58f4-4a75-9a1c-02ff1bb17294 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot AI self-assigned this May 19, 2026

Copilot AI review requested due to automatic review settings May 19, 2026 03:06

Copilot AI assigned MichalStrehovsky May 19, 2026

Copilot AI review requested due to automatic review settings May 19, 2026 03:06

Copilot created this pull request from a session on behalf of MichalStrehovsky May 19, 2026 03:06 View session

github-actions Bot added the area-Infrastructure-libraries label May 19, 2026

MichalStrehovsky reviewed May 19, 2026

View reviewed changes

Copilot started work on behalf of MichalStrehovsky May 19, 2026 03:48 View session

Address analyzer suppression review feedback

737b3d6

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5a0b0c7b-d13e-4936-8392-ff08d859bc72 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 19, 2026 04:24

Use null-safe DiagnosticMethodInfo in DI tests

768bc81

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5a0b0c7b-d13e-4936-8392-ff08d859bc72 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 19, 2026 04:32

Copilot finished work on behalf of MichalStrehovsky May 19, 2026 04:34

Copilot AI requested a review from MichalStrehovsky May 19, 2026 04:34

build-analysis Bot mentioned this pull request May 19, 2026

[wasm] Tests failing with DirectoryNotFoundException trying to load test data #128293

Open

	#pragma warning disable IL3050
	#pragma warning disable IL3050 // s_ZipPackagePartPieceType is a reference type, this is safe to suppress

	foreach (TlsCipherSuite cs in typeof(TlsCipherSuite).GetEnumValues())
	foreach (TlsCipherSuite cs in Enum.GetValues<TlsCipherSuite>())

	Assert.Equal(bypassedAddresses, (string[])p.BypassArrayList.ToArray(typeof(string)));
	Assert.Equal(bypassedAddresses, p.BypassArrayList.Cast<string>().ToArray());

Conversation

Copilot AI commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

dotnet-policy-service Bot commented May 19, 2026

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 19, 2026 •

edited

Loading