Relax address-family check in DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily on Android/AppleMobile#128404
Draft
Copilot wants to merge 2 commits into
Draft
Relax address-family check in DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily on Android/AppleMobile#128404Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…roid/AppleMobile Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure for DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily
Relax address-family check in DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily on Android/AppleMobile
May 20, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On android-arm64,
DnsGetHostEntry_LocalhostSubdomain_RespectsAddressFamily(InterNetwork)flakes because the Android OS resolver returns link-local IPv6 entries (e.g.fe80::…%47) alongside the requested IPv4 results fortest.localhost, soAssert.AlloverAddressListfails on the wrong-family entries.Changes:
src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs, on Android and Apple mobile, require only that the requested family is represented (Assert.Contains) and skip the per-addressAssert.Allcheck. Strict validation is preserved on all other platforms.DnsGetHostEntry_LocalhostAndSubdomain_BothReturnLoopbackin the same file.VerifyAddressFamilyhelper to avoid duplication.