Skip to content

Disable ExpressionsUnwrapeExternallyThrownRuntimeWrappedException on Wasm CoreCLR#128475

Merged
oroztocil merged 2 commits into
mainfrom
copilot/disable-test-wasm-coreclr
May 22, 2026
Merged

Disable ExpressionsUnwrapeExternallyThrownRuntimeWrappedException on Wasm CoreCLR#128475
oroztocil merged 2 commits into
mainfrom
copilot/disable-test-wasm-coreclr

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

System.Linq.Expressions.Tests.ExceptionHandlingExpressions.ExpressionsUnwrapeExternallyThrownRuntimeWrappedException fails on Wasm CoreCLR (tracked by #128164).

Description

  • Added an [ActiveIssue] attribute gated on PlatformDetection.IsBrowser && PlatformDetection.IsCoreCLR, matching the convention used elsewhere in the repo for Wasm CoreCLR-specific exclusions. The existing Mono [ActiveIssue] is preserved.
[Theory, ClassData(typeof(CompilationTypes))]
[ActiveIssue("https://github.com/mono/mono/issues/14925", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/128164", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void ExpressionsUnwrapeExternallyThrownRuntimeWrappedException(bool useInterpreter)

…Wasm CoreCLR

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/435c58eb-729d-4500-9888-6e0857fbe7f1

Co-authored-by: oroztocil <79744616+oroztocil@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 22, 2026 08:20
@oroztocil oroztocil marked this pull request as ready for review May 22, 2026 08:23
Copilot AI review requested due to automatic review settings May 22, 2026 08:23
@github-actions github-actions Bot added the area-ExceptionHandling-coreclr only use for closed issues label May 22, 2026
@oroztocil oroztocil enabled auto-merge (squash) May 22, 2026 08:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the System.Linq.Expressions exception-handling test suite to skip a single failing test case on Browser (Wasm) when running on CoreCLR by adding an [ActiveIssue] annotation with PlatformDetection.IsBrowser + PlatformDetection.IsCoreCLR gating.

Changes:

  • Added a new [ActiveIssue] entry for #128164 scoped to Browser + CoreCLR.
  • Kept the existing Mono-specific [ActiveIssue] unchanged for the same test.

@oroztocil oroztocil merged commit eb5503a into main May 22, 2026
93 of 95 checks passed
@oroztocil oroztocil deleted the copilot/disable-test-wasm-coreclr branch May 22, 2026 11:01
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ExceptionHandling-coreclr only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants